HBASE-24609 Move MetaTableAccessor out of hbase-client #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Introduced a CatalogFamilyFormat to place the method for generating/parsing cells in catalog family. |
|
This is for simplifying the implementation for HBASE-24608. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
Jun 24, 2020
|
|
||
| /** A regex for parsing server columns from meta. See above javadoc for meta layout */ | ||
| private static final Pattern SERVER_COLUMN_PATTERN = | ||
| Pattern.compile("^server(_[0-9a-fA-F]{4})?$"); |
There was a problem hiding this comment.
replica_id is a integer? So it should only have [0-9]?
There was a problem hiding this comment.
@InterfaceAudience.Private
String REPLICA_ID_FORMAT = "%04X";
I think it is in hex format?
saintstack
reviewed
Oct 13, 2020
| @@ -193,8 +133,8 @@ | |||
| * @param connection connection we're using | |||
| * @param visitor Visitor invoked against each row in regions family. | |||
| */ | |||
| public static void fullScanRegions(Connection connection, final Visitor visitor) | |||
| throws IOException { | |||
| public static void fullScanRegions(Connection connection, | |||
There was a problem hiding this comment.
Should this method be in ClientMTA altogether? Or you leave it here just to minimize code churn?
| return p.add(CellBuilderFactory.create(CellBuilderType.SHALLOW_COPY).setRow(p.getRow()) | ||
| .setFamily(HConstants.CATALOG_FAMILY) | ||
| .setQualifier(CatalogFamilyFormat.getSeqNumColumn(replicaId)).setTimestamp(p.getTimestamp()) | ||
| .setType(Type.Put).setValue(Bytes.toBytes(openSeqNum)).build()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Trying to figure the prinicipal to apply figuring when to put something in MTA and when to put it in CMTA? Thanks.
| * </pre> | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public class CatalogFamilyFormat { |
There was a problem hiding this comment.
Looks like could be package private?
There was a problem hiding this comment.
Only for the 'info' CF?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.