HBASE-24774 Space Quota violation policy Disable does not work at nam… #2142
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
tedyu
reviewed
Jul 27, 2020
| @@ -433,6 +433,11 @@ void updateNamespaceQuota( | |||
| LOG.info(tableInNS + " moving into violation of namespace space quota with policy " | |||
| + targetStatus.getPolicy()); | |||
| this.snapshotNotifier.transitionTable(tableInNS, targetSnapshot); | |||
| // when the Namespace is in violation due to Disable Policy, Disable the table | |||
| if (targetStatus.isInViolation() | |||
There was a problem hiding this comment.
snapshotNotifier.transitionTable may throw IOE.
Do you want to enclose the call to snapshotNotifier.transitionTable in try / catch block so that the new code would always run ?
There was a problem hiding this comment.
hi @tedyu yes I can enclose it in a try/catch but I have a small question. If the snapshotNotifier.transitionTable failed with an exception and if it is caught and the table is disabled, wouldn't there be inconsistency as the quota table will still show the table as non-violated(wrong usage and limit) but at the same time the table will be disabled because of Quota violation?
There was a problem hiding this comment.
The else block starting at line 418 is for targetStatus.isInViolation()
So if SpaceViolationPolicy.DISABLE is in effect, I think the table should be disabled.
We'd better keep quota table consistent with regard to the violation.
There was a problem hiding this comment.
Yes, that makes sense. I have updated the PR.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…espace level