Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24945 Remove MetaTableAccessor.getRegionCount #2303

Merged
merged 2 commits into from
Aug 25, 2020
Merged

HBASE-24945 Remove MetaTableAccessor.getRegionCount #2303

merged 2 commits into from
Aug 25, 2020

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Aug 24, 2020

No description provided.

@Apache9 Apache9 self-assigned this Aug 24, 2020
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 3m 39s master passed
+1 💚 checkstyle 1m 40s master passed
+1 💚 spotbugs 3m 11s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 23s the patch passed
-0 ⚠️ checkstyle 1m 4s hbase-server: The patch generated 4 new + 14 unchanged - 1 fixed = 18 total (was 15)
-0 ⚠️ checkstyle 0m 20s hbase-mapreduce: The patch generated 3 new + 80 unchanged - 9 fixed = 83 total (was 89)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 11m 9s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 3m 54s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
38m 42s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2303
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 98b47dfcee60 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e0c9f91
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-mapreduce U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 4m 12s master passed
+1 💚 compile 1m 55s master passed
+1 💚 shadedjars 5m 48s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-balancer in master failed.
-0 ⚠️ javadoc 0m 21s hbase-mapreduce in master failed.
-0 ⚠️ javadoc 0m 41s hbase-server in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 1m 57s the patch passed
+1 💚 javac 1m 57s the patch passed
+1 💚 shadedjars 6m 10s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-balancer in the patch failed.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in the patch failed.
_ Other Tests _
+1 💚 unit 0m 23s hbase-balancer in the patch passed.
-1 ❌ unit 7m 34s hbase-server in the patch failed.
+1 💚 unit 11m 2s hbase-mapreduce in the patch passed.
48m 30s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2303
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6aede26c35cf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e0c9f91
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/testReport/
Max. process+thread count 4884 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-mapreduce U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 3m 46s master passed
+1 💚 compile 1m 39s master passed
+1 💚 shadedjars 5m 49s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 11s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 36s the patch passed
+1 💚 compile 1m 38s the patch passed
+1 💚 javac 1m 38s the patch passed
+1 💚 shadedjars 5m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 11s the patch passed
_ Other Tests _
+1 💚 unit 0m 23s hbase-balancer in the patch passed.
-1 ❌ unit 144m 6s hbase-server in the patch failed.
+1 💚 unit 10m 3s hbase-mapreduce in the patch passed.
183m 0s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2303
Optional Tests javac javadoc unit shadedjars compile
uname Linux 46fefa8d9bbf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e0c9f91
Default Java 1.8.0_232
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/testReport/
Max. process+thread count 4575 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-mapreduce U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 4m 25s master passed
+1 💚 checkstyle 2m 7s master passed
+1 💚 spotbugs 4m 3s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 25s the patch passed
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-balancer
+1 💚 checkstyle 1m 17s hbase-server: The patch generated 0 new + 14 unchanged - 1 fixed = 14 total (was 15)
+1 💚 checkstyle 0m 23s hbase-mapreduce: The patch generated 0 new + 80 unchanged - 9 fixed = 80 total (was 89)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 14m 16s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 4m 47s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
48m 13s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2303
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 61d9d9bcadd9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6b0707f
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-mapreduce U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending QA

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 3m 58s master passed
+1 💚 compile 1m 51s master passed
+1 💚 shadedjars 6m 30s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-balancer in master failed.
-0 ⚠️ javadoc 0m 40s hbase-server in master failed.
-0 ⚠️ javadoc 0m 21s hbase-mapreduce in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 1m 55s the patch passed
+1 💚 javac 1m 55s the patch passed
+1 💚 shadedjars 6m 34s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-balancer in the patch failed.
-0 ⚠️ javadoc 0m 39s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 20s hbase-mapreduce in the patch failed.
_ Other Tests _
+1 💚 unit 0m 23s hbase-balancer in the patch passed.
+1 💚 unit 131m 49s hbase-server in the patch passed.
+1 💚 unit 9m 58s hbase-mapreduce in the patch passed.
173m 21s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2303
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8588dc3c533a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6b0707f
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/testReport/
Max. process+thread count 4844 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-mapreduce U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 3m 58s master passed
+1 💚 compile 1m 41s master passed
+1 💚 shadedjars 6m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 14s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 30s the patch passed
+1 💚 compile 1m 38s the patch passed
+1 💚 javac 1m 38s the patch passed
+1 💚 shadedjars 6m 33s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 23s hbase-balancer in the patch passed.
+1 💚 unit 145m 20s hbase-server in the patch passed.
+1 💚 unit 11m 8s hbase-mapreduce in the patch passed.
187m 40s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2303
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0640218fbd87 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6b0707f
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/testReport/
Max. process+thread count 3899 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-mapreduce U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2303/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 227084c into apache:master Aug 25, 2020
asfgit pushed a commit that referenced this pull request Aug 25, 2020
@Apache9
HBASE-24945 Remove MetaTableAccessor.getRegionCount (#2303)
0be2b6c 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@Apache9 @clarax
HBASE-24945 Remove MetaTableAccessor.getRegionCount (apache#2303)
51c8501 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Apache9 @Apache-HBase @virajjasani