Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24964 Remove MetaTableAccessor.tableExists #2330

Merged
merged 1 commit into from
Aug 30, 2020
Merged

HBASE-24964 Remove MetaTableAccessor.tableExists #2330

merged 1 commit into from
Aug 30, 2020

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Aug 30, 2020

No description provided.

@Apache9 Apache9 self-assigned this Aug 30, 2020
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 3m 39s master passed
+1 💚 checkstyle 1m 34s master passed
+1 💚 spotbugs 3m 9s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 22s the patch passed
-0 ⚠️ checkstyle 1m 7s hbase-server: The patch generated 4 new + 176 unchanged - 10 fixed = 180 total (was 186)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 18s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 3m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
37m 42s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2330
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 0100d1212180 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef5da4a
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-backup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending QA

hbase-balancer/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
return tableName.equals(TableName.META_TABLE_NAME) ||
getTableState(connection, tableName) != null;
}

/**
* Lists all of the regions currently in META.
* @param connection to connect with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get(TableName tableName) is a good candidate for returning Optional<TableDescriptor>, but anyways nothing related to this change. Can be taken up later.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 9s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 4m 48s master passed
+1 💚 compile 2m 0s master passed
+1 💚 shadedjars 7m 36s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 21s hbase-backup in master failed.
-0 ⚠️ javadoc 0m 17s hbase-balancer in master failed.
-0 ⚠️ javadoc 0m 44s hbase-server in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 31s the patch passed
+1 💚 compile 2m 6s the patch passed
+1 💚 javac 2m 6s the patch passed
+1 💚 shadedjars 7m 44s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-balancer in the patch failed.
-0 ⚠️ javadoc 0m 43s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 21s hbase-backup in the patch failed.
_ Other Tests _
+1 💚 unit 0m 26s hbase-balancer in the patch passed.
+1 💚 unit 143m 47s hbase-server in the patch passed.
+1 💚 unit 11m 39s hbase-backup in the patch passed.
192m 43s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2330
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2651ca1e798a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef5da4a
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/testReport/
Max. process+thread count 5009 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-backup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 4m 0s master passed
+1 💚 compile 1m 36s master passed
+1 💚 shadedjars 7m 12s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 7s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 48s the patch passed
+1 💚 compile 1m 37s the patch passed
+1 💚 javac 1m 37s the patch passed
+1 💚 shadedjars 7m 5s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 20s hbase-balancer in the patch passed.
+1 💚 unit 213m 13s hbase-server in the patch passed.
+1 💚 unit 13m 21s hbase-backup in the patch passed.
258m 16s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2330
Optional Tests javac javadoc unit shadedjars compile
uname Linux c0ca07353c11 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef5da4a
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/testReport/
Max. process+thread count 3571 (vs. ulimit of 12500)
modules C: hbase-balancer hbase-server hbase-backup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2330/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 2c4204a into apache:master Aug 30, 2020
asfgit pushed a commit that referenced this pull request Aug 30, 2020
@Apache9
HBASE-24964 Remove MetaTableAccessor.tableExists (#2330)
e022094 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@Apache9 @clarax
HBASE-24964 Remove MetaTableAccessor.tableExists (apache#2330)
3e0cfc3 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Apache9 @Apache-HBase @virajjasani