HBASE-24999 Master manages ReplicationServers #2397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ReplicationSourceManager (apache#2020) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…plicationSourceManager (apache#2019) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (apache#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…ationSink Service (apache#2111) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…e to a new interface ReplicationServerService (apache#2360) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ddupg
force-pushed
the
HBASE-24999
branch
2 times, most recently
from
fc3de0f
to
7d0763e
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
Sep 18, 2020
| String version = "0.0.0"; | ||
| VersionInfo versionInfo = VersionInfoUtil.getCurrentClientVersionInfo(); | ||
| if (versionInfo != null) { | ||
| version = versionInfo.getVersion(); |
There was a problem hiding this comment.
The difference of version and versionNumber is?
There was a problem hiding this comment.
versionNumber is packed by number part of version, can't display string suffixes like "-SNAPSHOT".
infraio
reviewed
Sep 18, 2020
| } | ||
| ClusterStatusProtos.ServerLoad sl = request.getLoad(); | ||
| ServerName serverName = ProtobufUtil.toServerName(request.getServer()); | ||
| ServerMetrics oldLoad = master.getReplicationServerManager().getLoad(serverName); |
There was a problem hiding this comment.
oldLoad => oldMetrics
getLoad => getServerMetrics
infraio
reviewed
Sep 18, 2020
| ClusterStatusProtos.ServerLoad sl = request.getLoad(); | ||
| ServerName serverName = ProtobufUtil.toServerName(request.getServer()); | ||
| ServerMetrics oldLoad = master.getReplicationServerManager().getLoad(serverName); | ||
| ServerMetrics newLoad = |
infraio
reviewed
Sep 18, 2020
| * Assumes onlineServers is locked. | ||
| * @return ServerName with matching hostname and port. | ||
| */ | ||
| private ServerName findServerWithSameHostnamePortWithLock(final ServerName serverName) { |
There was a problem hiding this comment.
"WithLock"... But where is the lock?
There was a problem hiding this comment.
Just keep same style with ServerManager. It means that onlineServers must be locked to access this method.
There was a problem hiding this comment.
But the impl didn't have a lock. And don't need to keep same style with ServerManager.
infraio
reviewed
Sep 18, 2020
| return null; | ||
| } | ||
|
|
||
| private void recordNewServerWithLock(final ServerName serverName, final ServerMetrics sl) { |
infraio
reviewed
Sep 18, 2020
| /** | ||
| * Expire the passed server. Remove it from list of online servers | ||
| */ | ||
| public void expireServerWithLock(final ServerName serverName) { |
infraio
reviewed
Sep 18, 2020
| * was started). This is used to differentiate a restarted instance of a given | ||
| * server from the original instance. | ||
| * <p> | ||
| * If a sever is known not to be running any more, it is called dead. The dead |
There was a problem hiding this comment.
Not record dead server now? Don't need these comments now.
…and decouple ReplicationSourceManager and ReplicationSource (apache#2364) Signed-off-by: meiyi <myimeiyi@gmail.com>
apache#2077) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
asfgit
force-pushed
the
HBASE-24666
branch
2 times, most recently
from
8dd91f4
to
6008ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.