HBASE-25053 WAL replay should ignore 0-length files #2437

nyl3532016 · 2020-09-22T03:21:40Z

No description provided.

Apache-HBase · 2020-09-22T03:59:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 15s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	spotbugs	2m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	checkstyle	1m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 33s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		37m 9s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux abc33ec778fa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8a6299b`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-22T06:21:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 12s	master passed
+1 💚	compile	1m 19s	master passed
+1 💚	shadedjars	7m 52s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 50s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 54s	the patch passed
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
+1 💚	shadedjars	8m 39s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 53s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	145m 43s	hbase-server in the patch passed.
		178m 56s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5d6374846d63 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8a6299b`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/testReport/
Max. process+thread count	3926 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-22T06:25:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	6m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	6m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	155m 22s	hbase-server in the patch passed.
		183m 8s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9857379d9c72 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8a6299b`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/testReport/
Max. process+thread count	3723 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Apache9 · 2020-09-22T13:49:46Z

This is just a simple optimization or something related to correctness?

I'm not sure whether at this step we have finished recoverLease for all the WAL files? I mean whether the length in the FileStatus can be trusted?

Thanks.

nyl3532016 · 2020-09-27T13:18:16Z

This is just a simple optimization or something related to correctness?

I'm not sure whether at this step we have finished recoverLease for all the WAL files? I mean whether the length in the FileStatus can be trusted?

Thanks.

Yes, we should invoke RecoverLeaseFSUtils.recoverFileLease in the method 'isZeroLengthThenDelete' ?

Apache-HBase · 2020-09-27T13:57:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 34s	master passed
+1 💚	checkstyle	1m 20s	master passed
+1 💚	spotbugs	2m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	checkstyle	1m 20s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		40m 3s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 3acef72a33fa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b57bef5`
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Apache-HBase · 2020-09-28T11:15:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	7m 56s	master passed
+1 💚	checkstyle	2m 23s	master passed
+1 💚	spotbugs	4m 45s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 54s	the patch passed
+1 💚	checkstyle	1m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 27s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		52m 57s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 0b9d8f7b5192 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `80ffac2`
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-28T13:16:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	shadedjars	7m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	7m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	147m 10s	hbase-server in the patch passed.
		174m 51s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6d2d6ca3fb08 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `80ffac2`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/testReport/
Max. process+thread count	3597 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-28T13:24:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 17s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	8m 46s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 49s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 7s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
+1 💚	shadedjars	8m 43s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 50s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	147m 53s	hbase-server in the patch failed.
		182m 29s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f74f5bc2113c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `80ffac2`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/testReport/
Max. process+thread count	3780 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-09-30T19:16:14Z

Yes, we should invoke RecoverLeaseFSUtils.recoverFileLease in the method 'isZeroLengthThenDelete' ?

This has not been added?

Files that have not been closed show as 0-length. I'm concerned looking at length will have us miss edits. Can you address my concern? Thanks.

nyl3532016 · 2020-10-01T14:11:13Z

Files that have not been closed show as 0-length. I'm concerned looking at length will have us miss edits. Can you address my concern? Thanks.

@saintstack as Duo Zhang comments in the above conversation? Anyway, my point here is that, make sure that when we call this method, we have already finished renaming the wal directory and calling recover lease on the wal files. Calling recoverLease and then re-get the FileStatus will generate extra load to NameNode. And I check the recoverFileLease is already invoked

Apache-HBase · 2020-10-02T03:08:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 41s	master passed
+1 💚	checkstyle	1m 26s	master passed
+1 💚	spotbugs	2m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 10s	the patch passed
+1 💚	checkstyle	1m 25s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 42s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 59s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		43m 37s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux c8bcd4e717a6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3b91a15`
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-02T05:15:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	shadedjars	6m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 33s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	6m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	144m 41s	hbase-server in the patch passed.
		171m 15s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 28815b2c9297 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3b91a15`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/testReport/
Max. process+thread count	3926 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-02T05:17:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 44s	master passed
+1 💚	compile	1m 14s	master passed
+1 💚	shadedjars	7m 12s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 47s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 58s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	8m 38s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 49s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	140m 18s	hbase-server in the patch passed.
		172m 40s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2437
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 20b6853860ee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3b91a15`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/testReport/
Max. process+thread count	4114 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2437/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

nyl3532016 · 2020-10-10T13:19:40Z

@Apache9 @saintstack This PR can be merged and closed?

nyl3532016 · 2020-10-19T02:19:59Z

@Apache9 @saintstack This PR can be merged and closed?

@saintstack please have a look, thanks

Apache9 · 2020-10-19T02:27:25Z

I‘m OK with merging.

saintstack · 2020-11-04T16:21:42Z

@nyl3532016 Sorry for delay.

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

virajjasani approved these changes Sep 22, 2020

View reviewed changes

nyl3532016 force-pushed the HBASE-25053 branch from 714367c to b3f83c0 Compare September 27, 2020 13:15

Apache9 requested changes Sep 27, 2020

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java Outdated Show resolved Hide resolved

nyl3532016 force-pushed the HBASE-25053 branch from b3f83c0 to f80000e Compare September 28, 2020 10:21

HBASE-25053 WAL replay should ignore 0-length files

33ed633

nyl3532016 force-pushed the HBASE-25053 branch from f80000e to 33ed633 Compare October 2, 2020 02:23

Apache9 approved these changes Oct 10, 2020

View reviewed changes

saintstack merged commit 0e71d61 into apache:master Nov 4, 2020

saintstack pushed a commit that referenced this pull request Nov 4, 2020

HBASE-25053 WAL replay should ignore 0-length files (#2437)

3d8152b

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-25053 WAL replay should ignore 0-length files (apache#2437)

aa4e418

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

nyl3532016 added a commit that referenced this pull request Nov 27, 2021

HBASE-25053 WAL replay should ignore 0-length files (#2437)

f76d6bc

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25053 WAL replay should ignore 0-length files #2437

HBASE-25053 WAL replay should ignore 0-length files #2437

nyl3532016 commented Sep 22, 2020

Apache-HBase commented Sep 22, 2020

Apache-HBase commented Sep 22, 2020

Apache-HBase commented Sep 22, 2020

virajjasani left a comment

Apache9 commented Sep 22, 2020

nyl3532016 commented Sep 27, 2020

Apache-HBase commented Sep 27, 2020

Apache-HBase commented Sep 28, 2020

Apache-HBase commented Sep 28, 2020

Apache-HBase commented Sep 28, 2020

saintstack commented Sep 30, 2020

nyl3532016 commented Oct 1, 2020

Apache-HBase commented Oct 2, 2020

Apache-HBase commented Oct 2, 2020

Apache-HBase commented Oct 2, 2020

nyl3532016 commented Oct 10, 2020

nyl3532016 commented Oct 19, 2020

Apache9 commented Oct 19, 2020

saintstack commented Nov 4, 2020

HBASE-25053 WAL replay should ignore 0-length files #2437

HBASE-25053 WAL replay should ignore 0-length files #2437

Conversation

nyl3532016 commented Sep 22, 2020

Apache-HBase commented Sep 22, 2020

Apache-HBase commented Sep 22, 2020

Apache-HBase commented Sep 22, 2020

virajjasani left a comment

Choose a reason for hiding this comment

Apache9 commented Sep 22, 2020

nyl3532016 commented Sep 27, 2020

Apache-HBase commented Sep 27, 2020

Apache-HBase commented Sep 28, 2020

Apache-HBase commented Sep 28, 2020

Apache-HBase commented Sep 28, 2020

saintstack commented Sep 30, 2020

nyl3532016 commented Oct 1, 2020

Apache-HBase commented Oct 2, 2020

Apache-HBase commented Oct 2, 2020

Apache-HBase commented Oct 2, 2020

nyl3532016 commented Oct 10, 2020

nyl3532016 commented Oct 19, 2020

Apache9 commented Oct 19, 2020

saintstack commented Nov 4, 2020