-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25112 Add new procedure metrics for master UI only #2469
base: master
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
d56a099
to
e4b486c
Compare
💔 -1 overall
This message was automatically generated. |
e4b486c
to
6b7e521
Compare
💔 -1 overall
This message was automatically generated. |
6b7e521
to
b882c52
Compare
🎊 +1 overall
This message was automatically generated. |
b882c52
to
c7a74af
Compare
* some cases where we should keep the history of some metrics for master UI, | ||
*/ | ||
@InterfaceAudience.Private | ||
public class OperationMetricsWithMasterUI extends OperationMetrics { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OperationMetricsWithMasterUI => OperationMetricsForMasterUI?
* @return Histogram of runtimes for all successfully completed instances of a type of a procedure | ||
* on master UI only | ||
*/ | ||
Histogram getTimeHistoOnMasterUI(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add to interface?
@@ -439,6 +439,10 @@ protected void updateMetricsOnFinish(TEnvironment env, long runtime, boolean suc | |||
if (timeHisto != null) { | |||
timeHisto.update(runtime); | |||
} | |||
Histogram timeHistoOnMasterUI = metrics.getTimeHistoOnMasterUI(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use "instance of" and cast to OperationMetricsForMasterUI. Then no need to add the method to interface?
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
c7a74af
to
e14f58f
Compare
💔 -1 overall
This message was automatically generated. |
e1ef1e5
to
cd88d5e
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
cd88d5e
to
79928d6
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Looks good. Whats it add to the UI @Joseph295 ? Put an image up on the JIRA? What failed here? Want me to rerun the PR so you can see what failed (not there any more it seems). |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
No description provided.