HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl… #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
cuibo01
force-pushed
the
HBASE-23340-master
branch
2 times, most recently
from
d901eb9
to
bb09955
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Nov 23, 2020
| @@ -60,10 +62,29 @@ public void preClean() { | |||
| wals = queueStorage.getAllWALs(); | |||
| } catch (ReplicationException e) { | |||
| LOG.warn("Failed to read zookeeper, skipping checking deletable files"); | |||
There was a problem hiding this comment.
Let's log this warn only if root cause of ReplicationException is not covered by below mentioned if condition.
Something like this:
catch (ReplicationException e) {
Throwable cause = e.getCause();
if (cause instanceof KeeperException.ConnectionLossException
|| cause instanceof KeeperException.SessionExpiredException
|| cause instanceof KeeperException.UnknownSessionException) {
try {
reconnectAfterKeeperException();
wals = queueStorage.getAllWALs();
return;
} catch (IOException | ReplicationException ex) {
LOG.warn("Failed to reconnect zookeeper or load all wal in replication queues.", ex);
}
} else {
LOG.warn("Failed to read zookeeper, skipping checking deletable files", e);
}
wals = null;
}
There was a problem hiding this comment.
@virajjasani update...
There was a problem hiding this comment.
@cuibo01 I think you missed putting warning in else block. Please check the sample provided above.
There was a problem hiding this comment.
no..i think it does not need else...and we can see the real exception
|
CleanerChore when runs each time, will try reconnect() if ZK session has expired right? What is the sleepPeriod configured in your environment where you tested this reconnect ZKWatcher changes? |
cuibo01
force-pushed
the
HBASE-23340-master
branch
from
bb09955
to
32048a4
Compare
…ication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWALs too large (more than 2TB)
cuibo01
force-pushed
the
HBASE-23340-master
branch
from
32048a4
to
91d54c0
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Nov 29, 2020
if this, we need to give HMaster/ZK to every Cleaner |
OK, so in ReplicationLogCleaner, we create our own ZKWatcher and ReplicationQueueStorage. Let's see if we could make it use the ones from HMaster? It is a bit confusing a add a updateZooKeeper method... |
|
I think we could make use of this method. When creating HFileCleaner, we will set HMaster into the map and the actual cleaners could get HMaster from the map. I think we could do the same for LogCleaners, to get ZKWatcher from HMaster, then there will be no problem if we hit session expired as the HMaster will abort itself so we do not need to recover. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWALs too large (more than 2TB)