HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@virajjasani @saintstack please take a look! |
virajjasani
reviewed
Nov 25, 2020
| } | ||
| System.err.println( | ||
| "To shutdown the master run " + | ||
| "hbase-daemon.sh stop HMaster or send a kill signal to " + |
There was a problem hiding this comment.
Isn't it hbase-daemon.sh stop master?
| "To shutdown the master run " + | ||
| "hbase-daemon.sh stop HMaster or send a kill signal to " + | ||
| "the HMaster pid, " + | ||
| "and to stop HBase Cluster run stop-hbase.sh or add --forceStop"); |
There was a problem hiding this comment.
nit: and to stop HBase Cluster either run stop-hbase.sh or add --forceStop with current command
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Nov 26, 2020
| @@ -62,7 +62,9 @@ | |||
| " --localRegionServers=<servers> " + | |||
| "RegionServers to start in master process when in standalone mode.\n" + | |||
| " --masters=<servers> Masters to start in this process.\n" + | |||
| " --backup Master should start in backup mode"; | |||
| " --backup Master should start in backup mode" + | |||
| " --forceStop " + | |||
There was a problem hiding this comment.
I think forceStop is generally referred to when we want to non-gracefully shutdown any service. Let's use flag --shutDownCluster instead.
| "To shutdown the master run " + | ||
| "hbase-daemon.sh stop master or send a kill signal to " + | ||
| "the HMaster pid, " + | ||
| "and to stop HBase Cluster run stop-hbase.sh or add --forceStop with current command"); |
There was a problem hiding this comment.
Here we can specify the exact command to be used:
and to stop HBase Cluster run: "stop-hbase.sh --shutDownCluster" or "hbase master stop --shutDownCluster"
Sounds good?
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Nov 26, 2020
Comment on lines
+25
to
+26
| usage="Usage: stop-hbase.sh can only be used for shutting down entire cluster\ | ||
| to shut down (HMaster|HRegionServer) use hbase-daemon.sh stop (master|regionserver)" |
| "To shutdown the master run " + | ||
| "hbase-daemon.sh stop master or send a kill signal to " + | ||
| "the HMaster pid, " + | ||
| "and to stop HBase Cluster run stop-hbase.sh or add --shutDownCluster with current command"); |
There was a problem hiding this comment.
nit:
and to stop HBase Cluster run: "stop-hbase.sh" or "hbase master stop --shutDownCluster"
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
Nov 27, 2020
…ter only Closes #2705 Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Nov 27, 2020
…ter only Closes #2705 Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Nov 27, 2020
…ter only Closes #2705 Signed-off-by: Viraj Jasani <vjasani@apache.org>
ramkrish86
pushed a commit
to ramkrish86/hbase
that referenced
this pull request
Dec 8, 2020
…ter only Closes apache#2705 Signed-off-by: Viraj Jasani <vjasani@apache.org>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…ter only Closes apache#2705 Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit f7ae870) Change-Id: I9fca561554510759b20478f20277c3a39f214488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.