HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit… #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
LGTM |
nyl3532016
approved these changes
Dec 6, 2020
Apache9
approved these changes
Dec 7, 2020
| if (HFileLink.isHFileLink(filePath)) return true; | ||
| public boolean isFileDeletable(FileStatus fStat) { | ||
| try { | ||
| lock.readLock().lock(); |
There was a problem hiding this comment.
Usually we will put this line before the try block.
| public boolean isFileDeletable(FileStatus fStat) { | ||
| try { | ||
| lock.readLock().lock(); | ||
| if (this.fs == null) return false; |
There was a problem hiding this comment.
nits: add '{}' to hold the 'return false;' block to fix a checkstyle warning.
| if (this.fs == null) return false; | ||
| Path filePath = fStat.getPath(); | ||
| // HFile Link is always deletable | ||
| if (HFileLink.isHFileLink(filePath)) return true; |
| super.setConf(conf); | ||
|
|
||
| // setup filesystem | ||
| try { | ||
| lock.writeLock().lock(); |
There was a problem hiding this comment.
Better move this line before the try block.
|
🎊 +1 overall
This message was automatically generated. |
|
Please fix the checkstyle issue? Looks like they are all line length too long, the width should 100, not 120. |
|
🎊 +1 overall
This message was automatically generated. |
|
now here are three commits, It should be only one commit |
Ah, this is not a problem. Just choose 'Squash and merge' when merging the PR, and modify the commit message accordingly. |
…eLock instead of synchronize
|
Thanks for reviewing @Apache9 @nyl3532016 . I have fixed the checkstyle issue and merged the commits to one(to make merging simple and conveniently). |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
nyl3532016
pushed a commit
that referenced
this pull request
Dec 8, 2020
…eLock instead of synchronize Closes #2738 Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Yulin Niu <niuyulin@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eLock instead of synchronize