HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t… #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he double comparison process
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
nyl3532016
reviewed
Dec 6, 2020
| } | ||
| } | ||
| return minMidpoint; | ||
| //Note that left[diffIdx] can never be equal to 0xff since left < right |
There was a problem hiding this comment.
The logic here is different from original?
There was a problem hiding this comment.
The logic of composing midPoint is basically the same, with some small differences
There was a problem hiding this comment.
(diffByte + 1) < (ByteBufferUtils.toByte(right, rightOffset + diffIdx) & 0xff)
I think this logical branch is lost
nyl3532016
reviewed
Dec 6, 2020
| byte[] minimumMidpointArray = new byte[minLength + 1]; | ||
| ByteBufferUtils | ||
| .copyFromBufferToArray(minimumMidpointArray, right, rightOffset, 0, minLength + 1); | ||
| minimumMidpointArray[minLength] = 0x00; |
There was a problem hiding this comment.
Here is different from original?
There was a problem hiding this comment.
Yes, I made some adjustments.
saintstack
approved these changes
Dec 7, 2020
| @@ -366,8 +366,6 @@ private void finishBlock() throws IOException { | |||
| */ | |||
| public static Cell getMidpoint(final CellComparator comparator, final Cell left, | |||
| final Cell right) { | |||
| // TODO: Redo so only a single pass over the arrays rather than one to | |||
There was a problem hiding this comment.
From HBASE-10800 ... By our Ramkrishna
|
@saintstack Thanks for reviewing |
|
@nyl3532016 You good w/ this change? If so, would like to add you as a sign-off. Thanks. |
@saintstack, I am good with the patch after @GeorryHuang amend a bit |
saintstack
pushed a commit
that referenced
this pull request
Feb 10, 2021
…he double comparison process (#2741) Signed-off-by: niuyulin <nyl353@163.com> Signed-off-by: stack <stack@apache.org>
ddupg
pushed a commit
to ddupg/hbase
that referenced
this pull request
Feb 19, 2021
…he double comparison process (apache#2741) Signed-off-by: niuyulin <nyl353@163.com> Signed-off-by: stack <stack@apache.org>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
Feb 24, 2021
…he double comparison process (apache#2741) Signed-off-by: niuyulin <nyl353@163.com> Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he double comparison process
There is a TODO like this "TODO: Redo so only a single pass over the arrays rather than one to compare and then a second composing midpoint." in getMidpoint() of class HFileWriteImpl
The old logic compares the left byte array and the right byte array twice：
My optimization combines them into one