HBASE-25383: Ability to update and remove peer base config #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
gjacoby126
requested changes
Dec 14, 2020
...ient/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
Outdated
Show resolved
Hide resolved
...ient/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bharathv
requested changes
Dec 15, 2020
...ient/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
Outdated
Show resolved
Hide resolved
...ient/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
Outdated
Show resolved
Hide resolved
sandeepvinayak
force-pushed
the
HBASE-25383
branch
from
8916bec
to
72d293a
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bharathv
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
A bunch of nits but lgtm. I think this approach is easy to reason about compared to the original version of the patch. There will be some weird edge cases here too but I think we can live with them.
@gjacoby126 any thoughts on this approach or is this good to go?
...ient/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java
Show resolved
Hide resolved
| getConfiguration().get(secondCustomPeerConfigKey)); | ||
| } finally { | ||
| shutDownMiniClusters(); | ||
| baseConfiguration.unset(ReplicationPeerConfigUtil.HBASE_REPLICATION_PEER_BASE_CONFIG); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testBasePeerConfigsRemovalForPeerMutations() |
There was a problem hiding this comment.
nit: Use a word other than mutation given it has a different meaning in HBase context? or may be just call it testBasePeerConfigRemoval..
| } | ||
|
|
||
| @Test | ||
| public void testRemoveBasePeerConfigWithoutExistingConfigForPeerMutations() |
|
I think this approach of removing key if
For rolling upgrade, updating configs in new bits is common before performing rolling restart of master and RS (which can also update config symlinks e.g /etc/conf/hbase), hence this patch should fit well for upgrades IMHO. With this patch, it's just like updating any other config. +1 for the PR overall once @bharathv and @gjacoby126 's remaining comments are addressed. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
gjacoby126
approved these changes
Dec 16, 2020
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
Dec 18, 2020
Closes #2778 Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Dec 18, 2020
Closes #2778 Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Dec 22, 2020
Closes #2778 Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we cannot update the peer based config even if we change the value of config.
Secondly, once the configuration is added, there is not smooth way to remove the peer config.
This patch adds an ability to update and remove the peer config if required.