HBASE-25558:Adding audit log for execMasterService #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Mar 29, 2021
changed to AUDITLOG |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
reviewed
Mar 29, 2021
| String remoteAddress = RpcServer.getRemoteAddress().map(InetAddress::toString).orElse(""); | ||
| User caller = RpcServer.getRequestUser().orElse(null); | ||
| AUDITLOG.info("User {} (remote address: {}) master service request for {}.{}", caller, | ||
| remoteAddress, serviceName, methodName); |
There was a problem hiding this comment.
Can we log more than methodName or perhaps methodName is what we usually put in audit log?
There was a problem hiding this comment.
methodName is what we usually put in audit log. We need to know what method is called by client when we are attacked!
There was a problem hiding this comment.
I was hoping for more than just method name if possible... like region name or table name if possible?
There was a problem hiding this comment.
I have checked the related code, there is no easy way to obtain infomration like region name or table name
|
Rerunning. Failures look unrelated. One comment above otherwise. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
pushed a commit
that referenced
this pull request
Mar 31, 2021
Signed-off-by: stack <stack@apache.org>
saintstack
pushed a commit
that referenced
this pull request
Mar 31, 2021
Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi:
I have found that in APIs, like execProcedure and execProcedureWithRet, have audit log to record who execute the master service. The log can be like:
LOG.info(master.getClientIdAuditPrefix() + " procedure request for: " + desc.getSignature());`
But it seems that we forget to audit execMasterService. We should add one.
old request is #2937