HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes… #3124

chrajeshbabu · 2021-04-05T18:26:23Z

…criptorBuilder#setValue leading to servers down(Rajeshbabu)

Apache-HBase · 2021-04-05T18:54:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 0s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	7m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	7m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 55s	hbase-client in the patch failed.
		27m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 978470b3f98a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `048ca4e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/testReport/
Max. process+thread count	338 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-05T19:01:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 2s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	8m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	8m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 15s	hbase-client in the patch failed.
		34m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 119e9d9adfc6 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `048ca4e`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/testReport/
Max. process+thread count	217 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-05T19:06:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	spotbugs	1m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 35s	the patch passed
-1 ❌	compile	0m 41s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 41s	hbase-client in the patch failed.
-0 ⚠️	checkstyle	0m 28s	hbase-client: The patch generated 3 new + 51 unchanged - 1 fixed = 54 total (was 52)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 53s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	1m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		38m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 048b915da835 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `048ca4e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

Tricky problem, but seems like a nice improvement.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java

joshelser · 2021-04-05T19:50:06Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java

+    ATTRIBUTE_VALIDATOR.put(IN_MEMORY_COMPACTION_BYTES,
+      (im) -> MemoryCompactionPolicy.valueOf(im.toString()));
+    ATTRIBUTE_VALIDATOR.put(COMPRESSION_COMPACT_BYTES,
+      (ca) -> Compression.Algorithm.valueOf(ca.toString()));


Doing the client-side validation is an improvement over what we have today. Can we do a server-side validation check as well?

For example, if a client is using new libraries than the server does, and (hypothetically) the client knows about some newer enum value that the server doesn't. A client-side check would fail first.

Should be pretty straightforward to add a new step into CreateTableProcedure and ModifyTableProcedure to check the HTD the user provides.

hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java

Lines 280 to 286 in 202b17f

private void preCreate(final MasterProcedureEnv env)

throws IOException, InterruptedException {

if (!getTableName().isSystemTable()) {

ProcedureSyncWait.getMasterQuotaManager(env)

.checkNamespaceTableAndRegionQuota(

getTableName(), (newRegions != null ? newRegions.size() : 0));

}

hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java

Lines 287 to 328 in 202b17f

private void prepareModify(final MasterProcedureEnv env) throws IOException {

// Checks whether the table exists

if (!env.getMasterServices().getTableDescriptors().exists(getTableName())) {

throw new TableNotFoundException(getTableName());

}

// check that we have at least 1 CF

if (modifiedTableDescriptor.getColumnFamilyCount() == 0) {

throw new DoNotRetryIOException("Table " + getTableName().toString() +

" should have at least one column family.");

}

// If descriptor check is enabled, check whether the table descriptor when procedure was

// submitted matches with the current

// table descriptor of the table, else retrieve the old descriptor

// for comparison in order to update the descriptor.

if (shouldCheckDescriptor) {

if (TableDescriptor.COMPARATOR.compare(unmodifiedTableDescriptor,

env.getMasterServices().getTableDescriptors().get(getTableName())) != 0) {

LOG.error("Error while modifying table '" + getTableName().toString()

+ "' Skipping procedure : " + this);

throw new ConcurrentTableModificationException(

"Skipping modify table operation on table '" + getTableName().toString()

+ "' as it has already been modified by some other concurrent operation, "

+ "Please retry.");

}

} else {

this.unmodifiedTableDescriptor =

env.getMasterServices().getTableDescriptors().get(getTableName());

}

this.deleteColumnFamilyInModify = isDeleteColumnFamily(unmodifiedTableDescriptor,

modifiedTableDescriptor);

if (!unmodifiedTableDescriptor.getRegionServerGroup()

.equals(modifiedTableDescriptor.getRegionServerGroup())) {

Supplier<String> forWhom = () -> "table " + getTableName();

RSGroupInfo rsGroupInfo = MasterProcedureUtil.checkGroupExists(

env.getMasterServices().getRSGroupInfoManager()::getRSGroup,

modifiedTableDescriptor.getRegionServerGroup(), forWhom);

MasterProcedureUtil.checkGroupNotEmpty(rsGroupInfo, forWhom);

}

}

TableDescriptorChecker handling most of the validations but checking for valid data block encoding is missed so added that so it should be fine both create and modify cases.

joshelser · 2021-04-05T19:51:14Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java

@@ -282,6 +283,8 @@

  private final static Set<Bytes> RESERVED_KEYWORDS = new HashSet<>();

+  private final static Map<Bytes,Function<Bytes,Object>> ATTRIBUTE_VALIDATOR = new HashMap<>();


If we want to do this same validation server-side, it would be nice to life the map and the validator functions out to their own class which can be more easily re-used.

Moved those to separate class.

chrajeshbabu · 2021-04-07T01:31:04Z

@joshelser Thanks for review please review updated changes. Thanks.

Apache-HBase · 2021-04-07T02:19:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 48s	master passed
+1 💚	compile	4m 9s	master passed
+1 💚	checkstyle	1m 33s	master passed
+1 💚	spotbugs	3m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s	the patch passed
-1 ❌	compile	0m 43s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 43s	hbase-client in the patch failed.
-0 ⚠️	checkstyle	0m 28s	hbase-client: The patch generated 4 new + 51 unchanged - 1 fixed = 55 total (was 52)
-0 ⚠️	checkstyle	1m 3s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 52s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		52m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 9edf470269cc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `048ca4e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-07T04:25:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 46s	master passed
+1 💚	compile	1m 27s	master passed
+1 💚	shadedjars	7m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 38s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	shadedjars	7m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 55s	hbase-client in the patch failed.
-1 ❌	unit	145m 56s	hbase-server in the patch failed.
		177m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cb646ad1be04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `048ca4e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/testReport/
Max. process+thread count	5027 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-07T05:31:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 43s	master passed
+1 💚	compile	1m 45s	master passed
+1 💚	shadedjars	8m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 44s	the patch passed
+1 💚	compile	1m 48s	the patch passed
+1 💚	javac	1m 48s	the patch passed
+1 💚	shadedjars	8m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 14s	hbase-client in the patch failed.
-1 ❌	unit	207m 12s	hbase-server in the patch failed.
		244m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6d0234dd1595 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `048ca4e`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/testReport/
Max. process+thread count	3136 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-23T08:26:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	4m 34s	master passed
+1 💚	checkstyle	1m 44s	master passed
+1 💚	spotbugs	3m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 1s	the patch passed
-1 ❌	compile	0m 46s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 46s	hbase-client in the patch failed.
-0 ⚠️	checkstyle	0m 28s	hbase-client: The patch generated 4 new + 51 unchanged - 1 fixed = 55 total (was 52)
-0 ⚠️	checkstyle	1m 8s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 10s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		59m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d5d914f5c8ec 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `96fefce`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-23T10:24:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	master passed
+1 💚	compile	1m 27s	master passed
+1 💚	shadedjars	7m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 38s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	7m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 10s	hbase-client in the patch passed.
-1 ❌	unit	144m 44s	hbase-server in the patch failed.
		177m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e7e2626bd34a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `96fefce`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/testReport/
Max. process+thread count	4608 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-23T11:37:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 57s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	8m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 47s	the patch passed
+1 💚	compile	1m 48s	the patch passed
+1 💚	javac	1m 48s	the patch passed
+1 💚	shadedjars	8m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 35s	hbase-client in the patch passed.
-1 ❌	unit	211m 30s	hbase-server in the patch failed.
		249m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a3db01adafd7 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `96fefce`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/testReport/
Max. process+thread count	3231 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-28T12:18:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 27s	master passed
+1 💚	compile	4m 45s	master passed
+1 💚	checkstyle	1m 34s	master passed
+1 💚	spotbugs	3m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
-1 ❌	compile	0m 45s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 45s	hbase-client in the patch failed.
-0 ⚠️	checkstyle	0m 29s	hbase-client: The patch generated 4 new + 55 unchanged - 1 fixed = 59 total (was 56)
-0 ⚠️	checkstyle	1m 4s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 38s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		56m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 88ae29cd991e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2382f68`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-28T14:21:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	shadedjars	8m 12s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 38s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	shadedjars	8m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 11s	hbase-client in the patch passed.
-1 ❌	unit	145m 48s	hbase-server in the patch failed.
		179m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6a638e78e442 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2382f68`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/testReport/
Max. process+thread count	4337 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-28T15:49:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 42s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 52s	master passed
+1 💚	compile	2m 28s	master passed
+1 💚	shadedjars	11m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 15s	the patch passed
+1 💚	compile	2m 19s	the patch passed
+1 💚	javac	2m 19s	the patch passed
+1 💚	shadedjars	10m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 7s	hbase-client in the patch passed.
+1 💚	unit	216m 50s	hbase-server in the patch passed.
		267m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dbe86155061d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2382f68`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/testReport/
Max. process+thread count	2733 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

Two very minor requests. Sorry it's so delayed.

joshelser · 2021-05-09T20:03:42Z

hbase-client/src/main/java/org/apache/hadoop/hbase/util/ColumnFamilyAttributeValidator.java

+        LOG.error(key.toString() + " attribute value "+ (value != null ? value.toString() : "")
+          + " is not valid.", e);


nit: use the {} notation to avoid a toString() penalty here

hbase-client/src/main/java/org/apache/hadoop/hbase/util/ColumnFamilyAttributeValidator.java

Apache-HBase · 2021-05-26T03:20:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 52s	master passed
+1 💚	compile	4m 15s	master passed
+1 💚	checkstyle	1m 32s	master passed
+1 💚	spotbugs	3m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 37s	the patch passed
-1 ❌	compile	0m 43s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 43s	hbase-client in the patch failed.
-0 ⚠️	checkstyle	0m 28s	hbase-client: The patch generated 4 new + 55 unchanged - 1 fixed = 59 total (was 56)
-0 ⚠️	checkstyle	1m 4s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 47s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		54m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 9e190936a932 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `19fd42b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-26T03:24:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 57s	master passed
+1 💚	compile	2m 4s	master passed
+1 💚	shadedjars	10m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 48s	the patch passed
+1 💚	compile	2m 11s	the patch passed
+1 💚	javac	2m 11s	the patch passed
+1 💚	shadedjars	9m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 52s	hbase-client in the patch passed.
-1 ❌	unit	13m 13s	hbase-server in the patch failed.
		58m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e322167d90c3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `19fd42b`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/testReport/
Max. process+thread count	668 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

+1 on QA. Thanks for addressing my suggestions, Rajeshbabu!

Apache-HBase · 2021-05-26T05:45:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 45s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	10m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 13s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 10s	the patch passed
+1 💚	compile	1m 46s	the patch passed
+1 💚	javac	1m 46s	the patch passed
+1 💚	shadedjars	10m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 26s	hbase-client in the patch passed.
+1 💚	unit	156m 5s	hbase-server in the patch passed.
		199m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux da98b9c0d1f4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `19fd42b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/testReport/
Max. process+thread count	4068 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-16T10:04:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 12s	master passed
+1 💚	compile	4m 24s	master passed
+1 💚	checkstyle	1m 36s	master passed
+1 💚	spotbugs	3m 15s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 57s	the patch passed
-1 ❌	compile	0m 46s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 46s	hbase-client in the patch failed.
-0 ⚠️	checkstyle	0m 28s	hbase-client: The patch generated 4 new + 55 unchanged - 1 fixed = 59 total (was 56)
-0 ⚠️	checkstyle	1m 2s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 30s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		58m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux ca9632a0bb23 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7bb2b9e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-16T13:27:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 27s	master passed
+1 💚	compile	1m 33s	master passed
+1 💚	shadedjars	9m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 3s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 18s	the patch passed
+1 💚	compile	1m 34s	the patch passed
+1 💚	javac	1m 34s	the patch passed
+1 💚	shadedjars	9m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 3s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 33s	hbase-client in the patch passed.
+1 💚	unit	218m 20s	hbase-server in the patch passed.
		261m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2b3dc95af6e4 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7bb2b9e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/testReport/
Max. process+thread count	3061 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-16T14:04:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 19s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	shadedjars	10m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 0s	the patch passed
+1 💚	compile	2m 20s	the patch passed
+1 💚	javac	2m 20s	the patch passed
+1 💚	shadedjars	10m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 14s	hbase-client in the patch passed.
+1 💚	unit	244m 8s	hbase-server in the patch passed.
		296m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6698d333c17c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7bb2b9e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/testReport/
Max. process+thread count	2957 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-23T03:35:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 6s	master passed
+1 💚	compile	4m 12s	master passed
+1 💚	checkstyle	1m 31s	master passed
+1 💚	spotbugs	3m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 50s	the patch passed
-1 ❌	compile	0m 45s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 45s	hbase-client in the patch failed.
-0 ⚠️	checkstyle	0m 29s	hbase-client: The patch generated 4 new + 55 unchanged - 1 fixed = 59 total (was 56)
-0 ⚠️	checkstyle	1m 2s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 5s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 55s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		58m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux a0a024308fcc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9e47358`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-23T06:53:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 34s	master passed
+1 💚	compile	1m 39s	master passed
+1 💚	shadedjars	9m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 17s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	9m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 3s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 32s	hbase-client in the patch passed.
+1 💚	unit	218m 57s	hbase-server in the patch passed.
		257m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 98fa0f570530 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9e47358`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/testReport/
Max. process+thread count	3997 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-23T07:32:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 14s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	10m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 32s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	shadedjars	10m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 15s	hbase-client in the patch passed.
-1 ❌	unit	247m 22s	hbase-server in the patch failed.
		294m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c9a7ca447970 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9e47358`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/testReport/
Max. process+thread count	2778 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

chrajeshbabu · 2021-11-09T16:55:17Z

retest build

HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…

a793ab3

…criptorBuilder#setValue leading to servers down(Rajeshbabu)

chrajeshbabu requested review from saintstack and joshelser April 5, 2021 18:27

joshelser requested changes Apr 5, 2021

View reviewed changes

Handling review comments

f1b8eeb

Fixing failed testcases

0808f49

Fixing test cases

43728c3

joshelser requested changes May 9, 2021

View reviewed changes

Handling review comments

cadb23d

joshelser approved these changes May 26, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes… #3124

HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes… #3124

chrajeshbabu commented Apr 5, 2021

Apache-HBase commented Apr 5, 2021

Apache-HBase commented Apr 5, 2021

Apache-HBase commented Apr 5, 2021

joshelser left a comment

joshelser Apr 5, 2021

chrajeshbabu Apr 7, 2021

joshelser Apr 5, 2021

chrajeshbabu Apr 7, 2021

chrajeshbabu commented Apr 7, 2021

Apache-HBase commented Apr 7, 2021

Apache-HBase commented Apr 7, 2021

Apache-HBase commented Apr 7, 2021

Apache-HBase commented Apr 23, 2021

Apache-HBase commented Apr 23, 2021

Apache-HBase commented Apr 23, 2021

Apache-HBase commented Apr 28, 2021

Apache-HBase commented Apr 28, 2021

Apache-HBase commented Apr 28, 2021

joshelser left a comment

joshelser May 9, 2021

chrajeshbabu May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

joshelser left a comment

Apache-HBase commented May 26, 2021

Apache-HBase commented Oct 16, 2021

Apache-HBase commented Oct 16, 2021

Apache-HBase commented Oct 16, 2021

Apache-HBase commented Oct 23, 2021

Apache-HBase commented Oct 23, 2021

Apache-HBase commented Oct 23, 2021

chrajeshbabu commented Nov 9, 2021

	private void preCreate(final MasterProcedureEnv env)
	throws IOException, InterruptedException {
	if (!getTableName().isSystemTable()) {
	ProcedureSyncWait.getMasterQuotaManager(env)
	.checkNamespaceTableAndRegionQuota(
	getTableName(), (newRegions != null ? newRegions.size() : 0));
	}

	private void prepareModify(final MasterProcedureEnv env) throws IOException {
	// Checks whether the table exists
	if (!env.getMasterServices().getTableDescriptors().exists(getTableName())) {
	throw new TableNotFoundException(getTableName());
	}

	// check that we have at least 1 CF
	if (modifiedTableDescriptor.getColumnFamilyCount() == 0) {
	throw new DoNotRetryIOException("Table " + getTableName().toString() +
	" should have at least one column family.");
	}

	// If descriptor check is enabled, check whether the table descriptor when procedure was
	// submitted matches with the current
	// table descriptor of the table, else retrieve the old descriptor
	// for comparison in order to update the descriptor.
	if (shouldCheckDescriptor) {
	if (TableDescriptor.COMPARATOR.compare(unmodifiedTableDescriptor,
	env.getMasterServices().getTableDescriptors().get(getTableName())) != 0) {
	LOG.error("Error while modifying table '" + getTableName().toString()
	+ "' Skipping procedure : " + this);
	throw new ConcurrentTableModificationException(
	"Skipping modify table operation on table '" + getTableName().toString()
	+ "' as it has already been modified by some other concurrent operation, "
	+ "Please retry.");
	}
	} else {
	this.unmodifiedTableDescriptor =
	env.getMasterServices().getTableDescriptors().get(getTableName());
	}

	this.deleteColumnFamilyInModify = isDeleteColumnFamily(unmodifiedTableDescriptor,
	modifiedTableDescriptor);
	if (!unmodifiedTableDescriptor.getRegionServerGroup()
	.equals(modifiedTableDescriptor.getRegionServerGroup())) {
	Supplier<String> forWhom = () -> "table " + getTableName();
	RSGroupInfo rsGroupInfo = MasterProcedureUtil.checkGroupExists(
	env.getMasterServices().getRSGroupInfoManager()::getRSGroup,
	modifiedTableDescriptor.getRegionServerGroup(), forWhom);
	MasterProcedureUtil.checkGroupNotEmpty(rsGroupInfo, forWhom);
	}
	}

		@@ -282,6 +283,8 @@

		private final static Set<Bytes> RESERVED_KEYWORDS = new HashSet<>();

		private final static Map<Bytes,Function<Bytes,Object>> ATTRIBUTE_VALIDATOR = new HashMap<>();

		LOG.error(key.toString() + " attribute value "+ (value != null ? value.toString() : "")
		+ " is not valid.", e);

HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes… #3124

Are you sure you want to change the base?

HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes… #3124

Conversation

chrajeshbabu commented Apr 5, 2021

Apache-HBase commented Apr 5, 2021

Apache-HBase commented Apr 5, 2021

Apache-HBase commented Apr 5, 2021

joshelser left a comment

Choose a reason for hiding this comment

joshelser Apr 5, 2021

Choose a reason for hiding this comment

chrajeshbabu Apr 7, 2021

Choose a reason for hiding this comment

joshelser Apr 5, 2021

Choose a reason for hiding this comment

chrajeshbabu Apr 7, 2021

Choose a reason for hiding this comment

chrajeshbabu commented Apr 7, 2021

Apache-HBase commented Apr 7, 2021

Apache-HBase commented Apr 7, 2021

Apache-HBase commented Apr 7, 2021

Apache-HBase commented Apr 23, 2021

Apache-HBase commented Apr 23, 2021

Apache-HBase commented Apr 23, 2021

Apache-HBase commented Apr 28, 2021

Apache-HBase commented Apr 28, 2021

Apache-HBase commented Apr 28, 2021

joshelser left a comment

Choose a reason for hiding this comment

joshelser May 9, 2021

Choose a reason for hiding this comment

chrajeshbabu May 26, 2021

Choose a reason for hiding this comment

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

joshelser left a comment

Choose a reason for hiding this comment

Apache-HBase commented May 26, 2021

Apache-HBase commented Oct 16, 2021

Apache-HBase commented Oct 16, 2021

Apache-HBase commented Oct 16, 2021

Apache-HBase commented Oct 23, 2021

Apache-HBase commented Oct 23, 2021

Apache-HBase commented Oct 23, 2021

chrajeshbabu commented Nov 9, 2021