HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na… #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
busbey
requested changes
Aug 25, 2019
| @@ -166,4 +167,17 @@ public ProtobufMessageHandler getObjectFromMessage(byte[] message) throws IOExce | |||
| } | |||
| return this; | |||
| } | |||
|
|
|||
| public static void main(String[] args) { | |||
There was a problem hiding this comment.
Can we do this as a unit test instead of a main method someone has to run?
There was a problem hiding this comment.
This should actually be removed, just had temporarily added this in order to have a proper json string generated, to perform manual tests using an http client.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Sep 14, 2019
| * @return response code. | ||
| */ | ||
| @PUT | ||
| public Response putNoBody(final byte[] message, |
There was a problem hiding this comment.
I don't know how this works. When you remove this, the put gets called?
There was a problem hiding this comment.
For some reason, on branch-2 based versions, these putNoBody and postNoBody methods only get properly called if client sets content-type request header to "application/octet-stream". We don't explicit define any requirement for "binary" request content-type, on the REST API doc in the ref guide, so it seems clients had been working well without setting content-type, in hbase 1. I suspect the behaviour change might be due jersey version changes between branch-1 and branch-2.
This fix simply removed the additional method, so request is guaranteed to always go to same place and then payload validations are applied there.
saintstack
approved these changes
Sep 16, 2019
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
apache#524) Signed-off-by: stack <stack@apache.org> (cherry picked from commit f6ff970)
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
apache#524) Signed-off-by: stack <stack@apache.org> (cherry picked from commit f6ff970) (cherry picked from commit 81ac896) Change-Id: I0e46aa2d6d4ff1914c59e93a9168de7142f5817d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-22846:
First PR based on branch-2.1. Apparently, jersey does not support more than one method mapped for the very same endpoint path, so merged post with postNobody, as well as put and putNobody. Additional refactoring applied to avoid code duplication.