HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded #714

apurtell · 2019-10-12T00:34:46Z

No description provided.

smerkerg · 2019-10-12T00:57:11Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java

    @Override
    protected double cost() {
-      if (!cluster.hasRegionReplicas) {


We should leave these lines here. isNeeded is only called by the needsBalance call site. But cost will still be called when a balance is determined to be needed.

it should follow same logic as RegionReplicaHostCostFunction

…plement CostFunction#isNeeded

smerkerg

LGTM

Reidddddd

+1

Apache-HBase · 2019-10-12T04:25:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💛	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
💚	mvninstall	6m 30s	master passed
💚	compile	0m 57s	master passed
💚	checkstyle	1m 20s	master passed
💚	shadedjars	4m 42s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 38s	master passed
💙	spotbugs	4m 5s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	4m 4s	master passed
		_ Patch Compile Tests _
💚	mvninstall	4m 52s	the patch passed
💚	compile	0m 57s	the patch passed
💚	javac	0m 57s	the patch passed
💚	checkstyle	1m 18s	the patch passed
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	5m 3s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	17m 18s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 35s	the patch passed
💚	findbugs	4m 17s	the patch passed
		_ Other Tests _
💔	unit	164m 51s	hbase-server in the patch failed.
💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		225m 5s

Reason	Tests
Failed junit tests	hadoop.hbase.master.balancer.TestStochasticLoadBalancerLargeCluster

Subsystem	Report/Notes
Docker	Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-714/1/artifact/out/Dockerfile
GITHUB PR	#714
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ab3ac8db1b49 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-714/out/precommit/personality/provided.sh
git revision	master / `1aee5f0`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-714/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-714/1/testReport/
Max. process+thread count	4993 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-714/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-10-12T08:25:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💛	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
💚	mvninstall	5m 48s	master passed
💚	compile	0m 57s	master passed
💚	checkstyle	1m 18s	master passed
💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 39s	master passed
💙	spotbugs	4m 30s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	4m 27s	master passed
		_ Patch Compile Tests _
💚	mvninstall	5m 11s	the patch passed
💚	compile	0m 58s	the patch passed
💚	javac	0m 58s	the patch passed
💚	checkstyle	1m 21s	the patch passed
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	4m 46s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	19m 14s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 44s	the patch passed
💚	findbugs	5m 7s	the patch passed
		_ Other Tests _
💚	unit	175m 11s	hbase-server in the patch passed.
💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		239m 0s

Subsystem	Report/Notes
Docker	Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-714/2/artifact/out/Dockerfile
GITHUB PR	#714
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 03726c4bc785 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-714/out/precommit/personality/provided.sh
git revision	master / `1aee5f0`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-714/2/testReport/
Max. process+thread count	4940 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-714/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org>

…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java

…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org>

…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java

…plement CostFunction#isNeeded (apache#714) Signed-off-by: Reid Chan <reidchan@apache.org>

…plement CostFunction#isNeeded (apache#714) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java (cherry picked from commit ea4a582) Change-Id: I649433e084897a91affde026d2701b73a8510af4

apurtell force-pushed the HBASE-23153 branch from ee48029 to 8a60157 Compare October 12, 2019 00:38

apurtell requested review from lhofhansl and xcangCRM October 12, 2019 00:46

smerkerg reviewed Oct 12, 2019

View reviewed changes

apurtell force-pushed the HBASE-23153 branch from 8a60157 to d2ed17f Compare October 12, 2019 01:13

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should im…

d2ed17f

…plement CostFunction#isNeeded

smerkerg approved these changes Oct 12, 2019

View reviewed changes

Reidddddd approved these changes Oct 12, 2019

View reviewed changes

apurtell merged commit 73d69c6 into apache:master Oct 12, 2019

apurtell deleted the HBASE-23153 branch October 12, 2019 20:14

asfgit pushed a commit that referenced this pull request Oct 12, 2019

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should im…

d66ed4c

…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org>

asfgit pushed a commit that referenced this pull request Oct 12, 2019

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should im…

56e0652

…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org>

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should im…

eac6458

…plement CostFunction#isNeeded (apache#714) Signed-off-by: Reid Chan <reidchan@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded #714

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded #714

apurtell commented Oct 12, 2019

smerkerg Oct 12, 2019

smerkerg Oct 12, 2019

apurtell Oct 12, 2019

smerkerg left a comment

Reidddddd left a comment

Apache-HBase commented Oct 12, 2019

Apache-HBase commented Oct 12, 2019

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded #714

HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded #714

Conversation

apurtell commented Oct 12, 2019

smerkerg Oct 12, 2019

Choose a reason for hiding this comment

smerkerg Oct 12, 2019

Choose a reason for hiding this comment

apurtell Oct 12, 2019

Choose a reason for hiding this comment

smerkerg left a comment

Choose a reason for hiding this comment

Reidddddd left a comment

Choose a reason for hiding this comment

Apache-HBase commented Oct 12, 2019

Apache-HBase commented Oct 12, 2019