-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded #714
Conversation
@Override | ||
protected double cost() { | ||
if (!cluster.hasRegionReplicas) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave these lines here. isNeeded
is only called by the needsBalance
call site. But cost
will still be called when a balance is determined to be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should follow same logic as RegionReplicaHostCostFunction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…plement CostFunction#isNeeded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org>
…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org>
…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
…plement CostFunction#isNeeded (#714) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
…plement CostFunction#isNeeded (apache#714) Signed-off-by: Reid Chan <reidchan@apache.org>
…plement CostFunction#isNeeded (apache#714) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java (cherry picked from commit ea4a582) Change-Id: I649433e084897a91affde026d2701b73a8510af4
No description provided.