Implement thread leakage check, fixing major thread leakage test and some flaky test

[kaisun2000]

• My PR addresses the following Helix issues and references them in the PR description:

resolve #1226, #1239, #1254, #1247, #1246, #1245, #1244, #1241, #1240 etc a bunch of unstable test

Description

• Here are some details about my PR, including screenshots of any UI changes:

There are some unit test not stable for various reasons. This PR addressed them.

Tests

• The following tests are written for this issue:

• The following is the result of the "mvn test" command on the appropriate module:

git hub run.

• In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

• My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Code Quality

• My diff has been formatted using helix-style.xml
  (helix-style-intellij.xml if IntelliJ IDE is used)

[junkaixue]

Please clean up the code. You have too many system.out.println. It could cause the test have more messed up info in test result.

[jiajunwang]

@kaisun2000 Let's don't keep adding more changes to the same PR. I think you have put 2 PRs into one change. It should be at least, 1. thread leakage check. 2. fixing the tests (I would prefer fixing them separately, but if the fixes are similar then it's OK).

[jiajunwang]

@kaisun2000 I strongly recommend splitting the logic changes from the pure testing fixes.
I mainly reviewed the logic change part. The test changes are too long to review. Could you please re-org the PR?

[kaisun2000]

@kaisun2000 I strongly recommend splitting the logic changes from the pure testing fixes.
I mainly reviewed the logic change part. The test changes are too long to review. Could you please re-org the PR?

Let us sync about it offline. There are conflict of different requirements.

1/ If our goal is to have all the test pass in github, we have to run it consistently till it converge to no failing test with all the changes in. Otherwise, how can we verify?
2/ The huge diff would be difficult to review. Yes, that is another concern.
3/ We have to make test converge quickly as people are checking in new code and potentially introducing new unstableness. We have to act quick, or it will not converge.

[jiajunwang]

Close due to inactive.