Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAGED Improvements: new constraints and replica sorting #1722

Merged
merged 4 commits into from
May 3, 2021

Conversation

NealSun96
Copy link
Contributor

@NealSun96 NealSun96 commented May 3, 2021

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

fix #1651, #1667, #1614, #1653

Description

  • Here are some details about my PR, including screenshots of any UI changes:

WAGED improvements:
#1652
#1658
#1668
#1691

Tests

  • The following is the result of the "mvn test" command on the appropriate module:
[INFO] Tests run: 1268, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5,082.355 s - in TestSuite
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1268, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-core ---
[INFO] Loading execution data file /home/nesun/helix/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 894 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:24 h
[INFO] Finished at: 2021-05-03T16:18:36-07:00
[INFO] ------------------------------------------------------------------------

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

NealSun96 and others added 4 commits April 23, 2021 14:17
Add new top state weight-based constraint to Waged to ensure top state weight evenness.

Co-authored-by: Neal Sun <nesun@nesun-mn1.linkedin.biz>
…aged (#1658)

This PR splits PartitionMovementConstraint into separate constraints that control baseline convergence and best possible movements respectively.

Co-authored-by: Neal Sun <nesun@nesun-mn1.linkedin.biz>
This PR increases largest possible rebalance preference ratio by enlarging the maximum weight from 10 to 1000.

Co-authored-by: Neal Sun <nesun@nesun-mn1.linkedin.biz>
…e replica with larger impact (#1691)

Improve the WAGED.ConstraintBasedAlgorithm sorting logic to prioritize replica with larger impact.
@jiajunwang jiajunwang merged commit fe4a9bb into master May 3, 2021
@jiajunwang jiajunwang deleted the wagedImprove branch May 3, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add top state usage-based constraint to Waged
3 participants