Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LockClient Minor Changes #2722

Closed
wants to merge 0 commits into from
Closed

LockClient Minor Changes #2722

wants to merge 0 commits into from

Conversation

Marcosrico
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2337

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Modifying constructor to not include not essential parameters. Private-ing helper methods to avoid confusion.

Tests

  • The following tests are written for this issue:

lockinfotest, lockclienttest

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@Marcosrico Marcosrico closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Marcosrico