Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]Tag with empty value Shouldn't transform to Tag: #2025

Merged
merged 2 commits into from
May 22, 2024

Conversation

JavaProgrammerLB
Copy link
Contributor

@JavaProgrammerLB JavaProgrammerLB commented May 22, 2024

What's changed?

Fix the issue

What is the bug

When I set Tag's name to 'TEST' and value to '',I expect to get TEST Tag, but sometime(when tag's value has set a value then delete the value to empty String) I get TEST:(with colon)

How to fix the bug

  • If the value is empty String(''),set the value to null

Effect

image
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@JavaProgrammerLB JavaProgrammerLB changed the title [manager]bug:Tag with empty value Shouldn't transform to Tag: [bugfix]Tag with empty value Shouldn't transform to Tag: May 22, 2024
@JavaProgrammerLB JavaProgrammerLB marked this pull request as draft May 22, 2024 07:32
@JavaProgrammerLB JavaProgrammerLB marked this pull request as ready for review May 22, 2024 08:03
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!👍

@tomsun28 tomsun28 merged commit 7a670e8 into apache:master May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] <标签值删除后,数据库value不为null,导致告警通知异常>
2 participants