Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manager-monitors](增强)应用服务检测-网站检测-分页:添加默认gmtUpdate降序 (enhancement)manager-monitors-page added gmtUpdate desc #457

Closed
wants to merge 2 commits into from

Conversation

luxx-lq
Copy link
Contributor

@luxx-lq luxx-lq commented Nov 22, 2022

[manager-monitors](增强)应用服务检测-网站检测-分页:添加默认gmtUpdate降序 (enhancement)manager-monitors-page added gmtUpdate desc

@tomsun28 tomsun28 self-requested a review November 22, 2022 06:15
@@ -67,7 +67,7 @@ public ResponseEntity<Message<Page<Monitor>>> getMonitors(
@Parameter(description = "en: Monitor Name,zh: 监控名称,模糊查询", example = "linux-127.0.0.1") @RequestParam(required = false) final String name,
@Parameter(description = "en: Monitor Host,zh: 监控Host,模糊查询", example = "127.0.0.1") @RequestParam(required = false) final String host,
@Parameter(description = "en: Monitor Status,zh: 监控状态 0:未监控,1:可用,2:不可用,3:不可达,4:挂起,9:全部状态", example = "1") @RequestParam(required = false) final Byte status,
@Parameter(description = "en: Sort Field,default id,zh: 排序字段,默认id", example = "name") @RequestParam(defaultValue = "id") final String sort,
@Parameter(description = "en: Sort Field,default id,zh: 排序字段,默认更新时间", example = "name") @RequestParam(defaultValue = "gmtUpdate") final String sort,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么默认要改为更新时间作为排序?
如果需要改的话,记得把”Sort Field,default id”也改了,“Sort Field,default gmtUpdate”

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是想实现这个issue #259 前端部分已修改合并
此PR和#455 相同,已合并上一个了
辛苦帮忙 @luxx-lqdescription = "en: Sort Field,default id同步修改下,不需要新建PR,在原分支commit会直接追加到PR中

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants