Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-25393: Prevent concurrent compaction and DDL operations #2503

Merged
merged 1 commit into from
Sep 14, 2021
Merged

HIVE-25393: Prevent concurrent compaction and DDL operations #2503

merged 1 commit into from
Sep 14, 2021

Conversation

deniskuzZ
Copy link
Member

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@deniskuzZ deniskuzZ requested a review from klcopp July 20, 2021 15:57
klcopp
klcopp reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@klcopp klcopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking – the goal of this change is to prevent concurrent compaction and DDL operations?

As discussed offline, verifyTableOrPartitionIdHasNotChanged might not be needed because if the table (or partition) was dropped, then the compaction has been removed from the queue and can't be marked failed, right? Or is it needed after all?

@deniskuzZ deniskuzZ changed the title HIVE-24235 fixup HIVE-25393: Prevent concurrent compaction and DDL operations Jul 27, 2021
@deniskuzZ
Copy link
Member Author

Just checking – the goal of this change is to prevent concurrent compaction and DDL operations?

As discussed offline, verifyTableOrPartitionIdHasNotChanged might not be needed because if the table (or partition) was dropped, then the compaction has been removed from the queue and can't be marked failed, right? Or is it needed after all?

it's started as HIVE-24235 , but once we introduced read locks that's no longer needed. I'll remove it, however, that would require some tests changes that mocked that method.

@klcopp
Copy link
Contributor

klcopp commented Jul 27, 2021

I think if it's not useful we should remove it. Keeping it would cause confusion for future maintainers.

@deniskuzZ
Copy link
Member Author

I think if it's not useful we should remove it. Keeping it would cause confusion for future maintainers.

done

@deniskuzZ deniskuzZ merged commit b1a90c6 into apache:master Sep 14, 2021
@deniskuzZ deniskuzZ deleted the HIVE-24235 branch September 14, 2021 09:37
HarshitGupta11 pushed a commit to HarshitGupta11/hive that referenced this pull request Dec 12, 2021
@deniskuzZ @HarshitGupta11
HIVE-25393: Prevent concurrent compaction and DDL operations (Denys K…
513de98 
…uzmenko, reviewed by Karen Coppage)

Closes (apache#2503)
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
@deniskuzZ @dengzhhu653
HIVE-25393: Prevent concurrent compaction and DDL operations (Denys K…
a428281 
…uzmenko, reviewed by Karen Coppage)

Closes (apache#2503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klcopp klcopp klcopp approved these changes

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deniskuzZ @klcopp @kgyrtkirk