-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-25969: Unable to reference table column named default #3045
Merged
kasakrisz
merged 8 commits into
apache:master
from
kasakrisz:HIVE-25969-master-default-keyword
May 10, 2022
Merged
HIVE-25969: Unable to reference table column named default #3045
kasakrisz
merged 8 commits into
apache:master
from
kasakrisz:HIVE-25969-master-default-keyword
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
Feb 22, 2022
kasakrisz
force-pushed
the
HIVE-25969-master-default-keyword
branch
from
February 22, 2022 16:26
6698b51
to
9e0fb56
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
Feb 22, 2022
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
kgyrtkirk
reviewed
May 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 pending tests
kasakrisz
force-pushed
the
HIVE-25969-master-default-keyword
branch
from
May 6, 2022 13:38
9e0fb56
to
0285651
Compare
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
tests failed
labels
May 6, 2022
kgyrtkirk
approved these changes
May 9, 2022
kasakrisz
force-pushed
the
HIVE-25969-master-default-keyword
branch
from
May 10, 2022 07:19
f4e99d3
to
1127ea4
Compare
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce parser token and rule for
default
keyword.Use the Token in SemanticAnalyzers when replacing
default
keyword with default constraint values.Why are the changes needed?
Prior this patch
default
keyword was treated as an identifier.default
in some cases.Does this PR introduce any user-facing change?
Yes, see jira for example.
How was this patch tested?