Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-25969: Unable to reference table column named default #3045

Merged
merged 8 commits into from
May 10, 2022

Conversation

kasakrisz
Copy link
Contributor

What changes were proposed in this pull request?

Introduce parser token and rule for default keyword.
Use the Token in SemanticAnalyzers when replacing default keyword with default constraint values.

Why are the changes needed?

Prior this patch

  • the default keyword was treated as an identifier.
  • and the lookup in the sql text was done by exact match of the string default in some cases.

Does this PR introduce any user-facing change?

Yes, see jira for example.

How was this patch tested?

mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=insert_into_default_keyword.q,insert_into_default_keyword_2.q -pl itests/qtest -Pitests
mvn test -Dtest=TestParseDefault -pl parser

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Apr 24, 2022
@github-actions github-actions bot closed this May 1, 2022
@kgyrtkirk kgyrtkirk reopened this May 2, 2022
Copy link
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending tests

@kasakrisz kasakrisz force-pushed the HIVE-25969-master-default-keyword branch from f4e99d3 to 1127ea4 Compare May 10, 2022 07:19
@github-actions github-actions bot requested a review from kgyrtkirk May 10, 2022 07:19
@kasakrisz kasakrisz merged commit 62834fb into apache:master May 10, 2022
@kasakrisz kasakrisz deleted the HIVE-25969-master-default-keyword branch May 10, 2022 11:46
@kasakrisz kasakrisz removed the stale label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants