HIVE-25173: [2.3] Migrate pentaho-aggdesigner-algorithm to aggdesigner-algorithm #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @sunchao |
sunchao
changed the title
|
Merged, thanks! |
SteBaum
pushed a commit
to TOSIT-IO/hive
that referenced
this pull request
Feb 2, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow the CALCITE-1474 to switch from
org.pentaho:pentaho-aggdesignertonet.hydromatic:aggdesigner.Why are the changes needed?
conjars repo is unavailable, we can not build success without local cache of
org.pentaho:pentaho-aggdesigner.The modules are from the same code base, and both are Apache licensed, and the latter is on maven central, so we can drop our dependency on Pentaho's maven repository.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
It's drop-in replacement.
How was this patch tested?
Before this change, I can not build success due to can not download the jar. The patch fixes it.