Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-27580: Backport HIVE-20071: Migrate to jackson 2.x and prevent usage #4564

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

wangyum
Copy link
Member

@wangyum wangyum commented Aug 8, 2023

What changes were proposed in this pull request?

This is the third step to remove dependency on jackson-core-asl and jackson-mapper-asl.

Why are the changes needed?

To fix SPARK-44719: NoClassDefFoundError when using Hive UDF.

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

@wangyum
Copy link
Member Author

wangyum commented Aug 8, 2023

cc @sunchao @pan3793

@pan3793
Copy link
Member

pan3793 commented Aug 8, 2023

Awesome! Thanks for your effort @wangyum

@wangyum
Copy link
Member Author

wangyum commented Aug 9, 2023

Add HIVE-22059 to fix:

mvn clean install -DskipTests=true
cd service && mvn test -DwildcardSuites=none -Dtest=org.apache.hive.service.cli.session.TestSessionHooks test

[INFO] Running org.apache.hive.service.cli.session.TestSessionHooks
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 3.236 s <<< FAILURE! - in org.apache.hive.service.cli.session.TestSessionHooks
[ERROR] org.apache.hive.service.cli.session.TestSessionHooks.testSessionHook  Time elapsed: 3.128 s  <<< ERROR!
java.lang.NoSuchFieldError: ALLOW_LEADING_DECIMAL_POINT_FOR_NUMBERS
        at com.fasterxml.jackson.core.json.JsonReadFeature.<clinit>(JsonReadFeature.java:121)
        at org.apache.hadoop.hive.ql.udf.UDFJson.<clinit>(UDFJson.java:69)
...

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunchao sunchao merged commit d9e96c9 into apache:branch-2.3 Aug 30, 2023
@sunchao
Copy link
Member

sunchao commented Aug 30, 2023

Merged to branch-2.3, thanks @wangyum !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants