Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-27651: Upgrade hbase version #4649

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Conversation

zhangbutao
Copy link
Contributor

@zhangbutao zhangbutao commented Sep 1, 2023

What changes were proposed in this pull request?

Upgrade hbase to latest stable version 2.5.6

Why are the changes needed?

HIVE-26124 has tried to upgrade hbase to 2.4.11, but it failed with hadoop3 compatibility problem.
From https://hbase.apache.org/downloads.html, Hbase2.5.6 seems to be compatible with hadoop3, so let's try to upgrade hbase to 2.5.6.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

How was this patch tested?

pom.xml Outdated
<hbase.version>2.0.0-alpha4</hbase.version>
<hbase.version>2.5.5</hbase.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be you need 2.5.5-hadoop3 here
https://mvnrepository.com/artifact/org.apache.hbase/hbase-client/2.5.5-hadoop3

can try that, if the test passes post that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggestion. I have used the 2.5.5 and 2.5.5-hadoop3 version, but both of the two failed.
I think Hbase2.5.5 has some compatibility issues with Hadoop3.3.1, and i have filed a Hbase ticket https://issues.apache.org/jira/browse/HBASE-28061. And i also find another ticket about Hbase2.5.5&Hadoop3.3.1 https://issues.apache.org/jira/browse/HBASE-28053. I hope that can get some valuable info from Hbase community.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any pointers, here I see you said on the ticket hbase built with 3.3.1 works fine

Copy link
Contributor Author

@zhangbutao zhangbutao Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need hbase team releases a hbase version againt hadoop3.3.1, but the hbase-hadoop3 official maven binaries was built againt hadoop3.2.4.

I test hbase with hadoop3.3.1 binary in my local maven which rebuild hbase with hadoop3.3.1 and it indeed works fine.

I have not explore the root cause, maybe need some time or need hbase community to help to fix this. :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2.5.6 is released, we can give that a try? HBASE-28061 was fixed in 2.5.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, Changed hbase version to 2.5.6. Thanks for reminding!

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@zhangbutao
Copy link
Contributor Author

Luckily, got a green pass. :)

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor doubt, rest LGTM

Found 3 items
drwxr-xr-x - ### USER ### ### GROUP ### 0 ### HDFS DATE ### hdfs://### HDFS PATH ###
Found 2 items
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this change? One entry got missing?

Copy link
Contributor Author

@zhangbutao zhangbutao Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i did a quick local test using hbase2.2.4 and hbase2.5.6:
I create a hbase table using Hbase shell command cli:

hbase:001:0> create 'mytable', 'cf1', 'cf2'
Created table mytable
  • I checked the hdfs data directory of the table in Hbase 2.2.4 and found it has three directory
Found 3 items
drwxr-xr-x   - root supergroup          0 2023-10-29 16:16 hdfs://localhost:8028/hbase224/data/default/mytable/.tabledesc
drwxr-xr-x   - root supergroup          0 2023-10-29 16:16 hdfs://localhost:8028/hbase224/data/default/mytable/.tmp
drwxr-xr-x   - root supergroup          0 2023-10-29 16:16 hdfs://localhost:8028/hbase224/data/default/mytable/556dcd44aa1534942170a780383ad2d3
  • I checked the hdfs data directory of the table in Hbase 2.5.6 and found it only has two directory
Found 2 items
drwxr-xr-x   - root supergroup          0 2023-10-29 16:44 hdfs://localhost:8028/hbase256/data/default/mytable/.tabledesc
drwxr-xr-x   - root supergroup          0 2023-10-29 16:44 hdfs://localhost:8028/hbase256/data/default/mytable/50cac0c44862cd5f9e8387677b0cc0ad

It is quite clear that new Hbase version(2.5.6) has changed its data directory structure, and this This change has nothing to do with Apache Hive.

Do you think my this test can prove that this change has nothing to do with Apache Hive?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, Will merge later today

@ayushtkn ayushtkn merged commit 40551ff into apache:master Oct 30, 2023
7 checks passed
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants