HIVE-27675: Support keystore/truststore types for hive/zookeeper i… #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegration (Naveen Gangam)
nrg4878
requested review from
abstractdog,
dengzhhu653 and
saihemanth-cloudera
|
@henrib @VenuReddy2103 Can you please review this change? Thank you |
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
dengzhhu653
approved these changes
Sep 13, 2023
henrib
approved these changes
Sep 13, 2023
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…ntegration (Naveen Gangam) (apache#4691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntegration (Naveen Gangam)
What changes were proposed in this pull request?
We have various points in the hive codebase that communicate with zookeeper service.
Apache Hive JDBC Driver fetches the HS2 URLs for service discovery.
Hive Server2 uses ZK to register itself for service discovery, table locking, ZK TokenStore etc.
Hive Metastore also uses ZK to register itself for service discovery, ZK Tokenstore
If Zookeeper is TLS enabled with a different keystore/truststore type, we need to be able to specify this type when establishing this connection. Otherwise, it defaults to JKS which may not be the case all the time.
Why are the changes needed?
To be able to support service discovery (and other features) that use zookeeper in hive, we have to allow for a keystore/truststore type to be specified in the config.
Does this PR introduce any user-facing change?
No, its backward compatible. But only in cases where non-JKS storetypes are used, we will need additional configuration either in the JDBC URL or in the hive-site.xml for HS2/HMS services.
Is the change a dependency upgrade?
No
How was this patch tested?
UTs