Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-27725: Remove redundant columns in TAB_COL_STATS and PART_COL_STATS tables #4744

Merged
merged 16 commits into from
Apr 9, 2024
Merged

HIVE-27725: Remove redundant columns in TAB_COL_STATS and PART_COL_STATS tables #4744

merged 16 commits into from
Apr 9, 2024

Conversation

wecharyu
Copy link
Contributor

What changes were proposed in this pull request?

  1. Remove CAT_NAME, DB_NAME and TABLE_NAME from TAB_COL_STATS table.
  2. Remove CAT_NAME, DB_NAME, TABLE_NAME and PARTITION_NAME columns from PART_COL_STATS table.

Why are the changes needed?

  1. Refine the metadata schema, remove redundant columns of TAB_COL_STATS and PART_COL_STATS
  2. Unify get table stats, update table stats and delete table stats, make sure all query use the join clause to avoid data inconsistency.

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

No.

How was this patch tested?

Add a new unit test.

@wecharyu
Copy link
Contributor Author

@saihemanth-cloudera @deniskuzZ @dengzhhu653: Could you help review this PR?

@wecharyu wecharyu mentioned this pull request Sep 27, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@deniskuzZ
Copy link
Member

some schema changes? Column 'CAT_NAME' cannot accept a NULL value

@deniskuzZ
Copy link
Member

@wecharyu, is that abandoned?

@wecharyu
Copy link
Contributor Author

wecharyu commented Apr 5, 2024

Not really, will check this issue. @deniskuzZ

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wecharyu
Copy link
Contributor Author

wecharyu commented Apr 9, 2024

@deniskuzZ CI turns green, the failed test was changed in previous commit, test passed after reverting it.

@deniskuzZ deniskuzZ merged commit 10ece7c into apache:master Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengzhhu653 dengzhhu653 dengzhhu653 left review comments

@nrg4878 nrg4878 nrg4878 left review comments

@deniskuzZ deniskuzZ deniskuzZ approved these changes

@zhangbutao zhangbutao zhangbutao approved these changes

@miklosgergely miklosgergely Awaiting requested review from miklosgergely

@saihemanth-cloudera saihemanth-cloudera Awaiting requested review from saihemanth-cloudera

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wecharyu @zhangbutao @nareshpr @dengzhhu653 @deniskuzZ @nrg4878 @asf-ci-hive