-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28077: Iceberg: Major QB Compaction on partition level #5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
Mar 9, 2024
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests failed
tests pending
tests unstable
labels
Mar 9, 2024
difin
force-pushed
the
compact_partition
branch
from
March 12, 2024 00:58
06e52ba
to
838faa8
Compare
difin
force-pushed
the
compact_partition
branch
from
March 12, 2024 02:09
838faa8
to
2c298d6
Compare
asf-ci-hive
added
tests passed
tests pending
tests unstable
and removed
tests pending
tests passed
labels
Mar 12, 2024
difin
force-pushed
the
compact_partition
branch
from
March 12, 2024 19:44
2c298d6
to
2bf323f
Compare
difin
force-pushed
the
compact_partition
branch
from
April 23, 2024 17:51
7dbeca1
to
06d68e1
Compare
deniskuzZ
reviewed
Apr 23, 2024
...-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Apr 23, 2024
...-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Apr 23, 2024
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
Apr 23, 2024
difin
force-pushed
the
compact_partition
branch
from
April 24, 2024 03:15
979dedf
to
e430bdc
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Apr 24, 2024
deniskuzZ
reviewed
Apr 24, 2024
...-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Apr 24, 2024
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1, minor code-style things
deniskuzZ
approved these changes
Apr 24, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding support for compacting a specific Iceberg partition
Why are the changes needed?
Until now it was possible to only compact whole the table at once. If a table is partitioned, it would compact all partitions.
Now adding a new feature to compact a single specified partition.
Does this PR introduce any user-facing change?
Ability to compact Iceberg tables on partition level.
Is the change a dependency upgrade?
No
How was this patch tested?
New q-test was added that compacts a partitioned table partition-by-partition.