You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
changed the title
Log the original exception in handleRecordReaderNextException
Log the original exception in HiveIOExceptionHandlerUtil#handleRecordReaderNextException
Mar 20, 2024
deniskuzZ
changed the title
Log the original exception in HiveIOExceptionHandlerUtil#handleRecordReaderNextException
HIVE-28133: Log the original exception in HiveIOExceptionHandlerUtil#handleRecordReaderNextException
Mar 20, 2024
it seems like a dead code with 0 implementations. should we then drop the whole stuff in 1 go? or maybe someone adds the handlers via aux jars?
deniskuzZ
changed the title
HIVE-28133: Log the original exception in HiveIOExceptionHandlerUtil#handleRecordReaderNextException
HIVE-28133: Log the original exception in HiveIOExceptionHandlerUtil#handleRecordReaderException
Mar 20, 2024
it seems like a dead code with 0 implementations. should we then drop the whole stuff in 1 go? or maybe someone adds the handlers via aux jars?
even if they add it via aux jars, I still don't get the point of defining flexible exception handlers for record reader exceptions, not even a single google match that made sense, so I believe we can let this awesome handler chain go :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deniskuzZ
changed the title
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
What changes were proposed in this pull request?
Logging improvements
Why are the changes needed?
Troubleshooting
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
on a cluster