-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-27102: Upgrade Calcite to 1.33.0 and Avatica to 1.23.0 #5196
Open
soumyakanti3578
wants to merge
87
commits into
apache:master
Choose a base branch
from
soumyakanti3578:calcite-upgrade-1.33
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HIVE-27102: Upgrade Calcite to 1.33.0 and Avatica to 1.23.0 #5196
soumyakanti3578
wants to merge
87
commits into
apache:master
from
soumyakanti3578:calcite-upgrade-1.33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
Apr 15, 2024
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
Apr 22, 2024
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
May 4, 2024
This was failing because during logical planning key*1 is getting reduced to key in 1.33, whereas it was not reduced in 1.25. Changing it to key*2 will stop the reduction.
`NOT(SEARCH(...))` is simplified to `SEARCH[(..), (...)]` in RexSimplify# simplifyNot Removed testComputeRangePredicateSelectivityNotBetweenRightLowerThanLeft as it is not possible to create a RexNode with right < left
tries. This can be removed after upgrading to Calcite 1.38 https://issues.apache.org/jira/browse/CALCITE-6453
… a max of 5" This reverts commit 9724d26.
soumyakanti3578
force-pushed
the
calcite-upgrade-1.33
branch
from
November 4, 2024 21:53
60566cc
to
4a9b512
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade Calcite to 1.33, Avatica to 1.23
Why are the changes needed?
Does this PR introduce any user-facing change?
Logical explain plans can have SEARCH operators instead of BETWEENs and INs
Is the change a dependency upgrade?
Yes
How was this patch tested?
With Ptests