HIVE-28285: Exception when querying JDBC tables with Hive/DB column types mismatch #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes mismatch 1. Revert changes from HIVE-27487 for fetching types from the database (RS) and restore the old behavior. 2. Enrich JDBC type conversion test matrix for Derby a. Increase type combinations b. Increase test row/values c. Test with CBO on/off When Hive types and database (DB) column types are different there is an implicit type conversion that must be done. The JdbcRecordIterator drives the type conversion, and the way we extract values from the ResultSet largely determines the result. In order to perform the conversion the iterator must use the Hive DDL types and not the database DDL types obtained from the result set.
|
dengzhhu653
approved these changes
Jun 3, 2024
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Jun 13, 2024
…ypes mismatch (Stamatis Zampetakis reviewed by Zhihua Deng) 1. Revert changes from HIVE-27487 for fetching types from the database (RS) and restore the old behavior. 2. Enrich JDBC type conversion test matrix for Derby a. Increase type combinations b. Increase test row/values c. Test with CBO on/off When Hive types and database (DB) column types are different there is an implicit type conversion that must be done. The JdbcRecordIterator drives the type conversion, and the way we extract values from the ResultSet largely determines the result. In order to perform the conversion the iterator must use the Hive DDL types and not the database DDL types obtained from the result set. Close apache#5274
mr3project
pushed a commit
to mr3project/hive-mr3
that referenced
this pull request
Aug 21, 2024
…ypes mismatch (Stamatis Zampetakis reviewed by Zhihua Deng) 1. Revert changes from HIVE-27487 for fetching types from the database (RS) and restore the old behavior. 2. Enrich JDBC type conversion test matrix for Derby a. Increase type combinations b. Increase test row/values c. Test with CBO on/off When Hive types and database (DB) column types are different there is an implicit type conversion that must be done. The JdbcRecordIterator drives the type conversion, and the way we extract values from the ResultSet largely determines the result. In order to perform the conversion the iterator must use the Hive DDL types and not the database DDL types obtained from the result set. Close apache/hive#5274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
When Hive types and database (DB) column types are different there is an implicit type conversion that must be done. The JdbcRecordIterator drives the type conversion, and the way we extract values from the ResultSet largely determines the result. In order to perform the conversion the iterator must use the Hive DDL types and not the database DDL types obtained from the result set.
Does this PR introduce any user-facing change?
Yes, as explained above.
Is the change a dependency upgrade?
No
How was this patch tested?