HIVE-28338: Client connection count is not correct in HiveMetaStore#close #5310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wecharyu
commented
Jun 18, 2024
| } | ||
| } catch (TException e) { | ||
| LOG.debug("Unable to shutdown metastore client. Will try closing transport directly.", e); | ||
| } | ||
| // Transport would have got closed via client.shutdown(), so we dont need this, but |
There was a problem hiding this comment.
client.shutdown() calls would not close transport in client side, we must close transport explicitly.
|
|
@zhangbutao @dengzhhu653 @saihemanth-cloudera could you pls review this pr? |
dengzhhu653
approved these changes
Jun 27, 2024
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Jul 18, 2024
…he#5310) (Wechar Yu, reviewed by Zhihua Deng, Sai Hemanth Gantasala)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HiveMetaStoreClientconnections.Why are the changes needed?
Bug fix, connection counts is used in remote metastore with
TTransport, so we cannot decrease counts when transport is null.Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
New test class:
mvn test -Dtest.groups= -Dtest=org.apache.hadoop.hive.metastore.client.TestHiveMetaStoreClient -pl :hive-standalone-metastore-server