Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-28315: Missing classes while using hive jdbc standalone jar #5313

Merged
merged 2 commits into from
Jul 20, 2024
Merged

HIVE-28315: Missing classes while using hive jdbc standalone jar #5313

merged 2 commits into from
Jul 20, 2024

Conversation

dengzhhu653
Copy link
Member

@dengzhhu653 dengzhhu653 commented Jun 19, 2024 •
edited
Loading

What changes were proposed in this pull request?

Add classes/trim dependencies to/from the jdbc standalone jar

Why are the changes needed?

  • Solve the missing classes
  • Reduce the jar size from 98M to 42M

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

  • Tested create/show/select/load queries, fetching the result;
  • Tested DatabaseMetaData;
  • Tested Kerberos & Delegation token & Simple authentication;
  • Tested using ZK for service discovery;
  • Inspected the classes inside the standalone jar.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@linghengqian linghengqian mentioned this pull request Jun 28, 2024
Merged
6 tasks
@linghengqian linghengqian mentioned this pull request Jul 18, 2024
Open
47 tasks
deniskuzZ
deniskuzZ approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@deniskuzZ deniskuzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@dengzhhu653 dengzhhu653 merged commit 3490488 into apache:master Jul 20, 2024
5 checks passed
@linghengqian linghengqian mentioned this pull request Jul 22, 2024
Closed
This was referenced Jul 31, 2024
Open
Open
dengzhhu653 added a commit to dengzhhu653/hive that referenced this pull request Aug 7, 2024
@dengzhhu653
HIVE-28315: Missing classes while using hive jdbc standalone jar (apa…
587aed2 
…che#5313) (Zhihua Deng, reviewed by Denys Kuzmenko)
@linghengqian linghengqian mentioned this pull request Aug 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniskuzZ deniskuzZ deniskuzZ approved these changes

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dengzhhu653 @deniskuzZ @asf-ci-hive