HIVE-22068 : Add more logging to notification cleaner and replication to track events #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh-bapat
force-pushed
the
hive22068
branch
from
3d9f504
to
bc4948b
Compare
ashutosh-bapat
force-pushed
the
hive22068
branch
from
bc4948b
to
cad5dfc
Compare
sankarh
requested changes
Aug 16, 2019
...it/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
Outdated
Show resolved
Hide resolved
...it/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
Outdated
Show resolved
Hide resolved
ashutosh-bapat
force-pushed
the
hive22068
branch
from
cad5dfc
to
9b49b26
Compare
sankarh
requested changes
Aug 17, 2019
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
Outdated
Show resolved
Hide resolved
| // available from the dump metadata. | ||
| String dbName = work.dbNameToLoadIn; | ||
| if (dbName == null || StringUtils.isNotBlank(dbName)) { | ||
| if (work.currentReplScope != null) { |
There was a problem hiding this comment.
Add a comment about in which scenario we hit this case.
There was a problem hiding this comment.
Done. Please check and suggest improvement if necessary.
ashutosh-bapat
force-pushed
the
hive22068
branch
from
9b49b26
to
c00ab73
Compare
The ptest failure comes because of mismatch in the repl status output and the last repl id reported by REPL DUMP. Now that we always set the first same as the later the expected output should change.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.