Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add resources configuration Helm Chart #2049

Closed
scali opened this issue Dec 12, 2022 · 2 comments
Closed

[Feature Request]: Add resources configuration Helm Chart #2049

scali opened this issue Dec 12, 2022 · 2 comments
Milestone

Comments

@scali
Copy link
Contributor

scali commented Dec 12, 2022

What would you like to happen?

Add resources section configuration in Helm Chart

Something like below (in hop-deployement.yaml file)

// Some comments here
apiVersion: apps/v1
kind: Deployment
...
spec:
  template:
    spec:
      containers:
            resources:
            {{- toYaml .Values.resources | nindent 12 }}

Issue Priority

Priority: 3

Issue Component

Component: Containers

@scali
Copy link
Contributor Author

scali commented Dec 12, 2022

I've got the willing to submit a PR

@hansva
Copy link
Contributor

hansva commented Dec 12, 2022

@scali , We love PR's ! feel free to create one!

@hansva hansva closed this as completed in 16d7353 Dec 12, 2022
hansva added a commit that referenced this issue Dec 12, 2022
Fix #2049 : Add resources configuration Helm Chart
@hansva hansva added this to the 2.3 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants