Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: kettle import replace in content for Javascript and UJDC #4340

Closed
nadment opened this issue Sep 20, 2024 · 1 comment · Fixed by #4350 or #4357
Closed

[Task]: kettle import replace in content for Javascript and UJDC #4340

nadment opened this issue Sep 20, 2024 · 1 comment · Fixed by #4350 or #4357
Assignees
@nadment
Labels
Import P3 Nice to have task
Milestone
2.10

Comments

@nadment
Copy link
Contributor

nadment commented Sep 20, 2024

What needs to happen?

Some mapping to add to kettleReplaceInContent

            // Javascript
            {"trans_Status", "pipeline_Status"},
            {"CONTINUE_TRANSFORMATION", "CONTINUE_PIPELINE"},
            {"SKIP_TRANSFORMATION", "SKIP_PIPELINE"},
            {"ERROR_TRANSFORMATION", "ERROR_PIPELINE"},
            {"ABORT_TRANSFORMATION", "ABORT_PIPELINE"},

            // UJDC
            {
              "processRow(StepMetaInterface smi, StepDataInterface sdi) throws KettleException",
              "processRow() throws HopException"
            },

Issue Priority

Priority: 3

Issue Component

Component: Import
@nadment nadment added the task label Sep 20, 2024
@nadment nadment self-assigned this Sep 20, 2024
@github-actions github-actions bot added P3 Nice to have Import labels Sep 20, 2024
nadment added a commit to nadment/hop that referenced this issue Sep 23, 2024
@nadment
Kettle import replace in content for Javascript and UJDC apache#4340
18c30ae
@nadment nadment linked a pull request Sep 23, 2024 that will close this issue
Kettle import replace in content for Javascript and UJDC #4340 #4350
Merged
hansva added a commit that referenced this issue Sep 25, 2024
@hansva
Merge pull request #4350 from nadment/4340
4c2d1ec 
Kettle import replace in content for Javascript and UJDC #4340
@hansva hansva added this to the 2.10 milestone Sep 25, 2024
@nadment
Copy link
Contributor Author

nadment commented Sep 25, 2024

Add an other conversion:
{"parent_job", "parent_workflow"},

@nadment nadment reopened this Sep 25, 2024
nadment added a commit to nadment/hop that referenced this issue Sep 25, 2024
@nadment
Kettle import replace in content for Action Javascript apache#4340
b859fc1
@nadment nadment linked a pull request Sep 25, 2024 that will close this issue
Kettle import replace in content for Action Javascript #4340 #4357
Merged
hansva added a commit that referenced this issue Sep 25, 2024
@hansva
Merge pull request #4357 from nadment/4340
3d46c53 
Kettle import replace in content for Action Javascript #4340
Adalennis pushed a commit to Adalennis/hop that referenced this issue Oct 1, 2024
@nadment @abuchillon
Kettle import replace in content for Javascript and UJDC apache#4340
7d692ae
Adalennis pushed a commit to Adalennis/hop that referenced this issue Oct 1, 2024
@nadment @abuchillon
Kettle import replace in content for Action Javascript apache#4340
fdeb071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
Import P3 Nice to have task
Projects
None yet
Milestone
2.10
2 participants
@hansva @nadment