Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of dialog constructors for actions and pipelines #4006 #4007

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

nadment
Copy link
Contributor

@nadment nadment commented Jun 1, 2024

No description provided.

@nadment nadment marked this pull request as draft June 1, 2024 17:43
@github-actions github-actions bot added the Neo4j label Jun 1, 2024
@nadment nadment changed the title Clean up of dialog constructors for actions #4006 Clean up of dialog constructors for actions and pipelines #4006 Jun 1, 2024
@nadment nadment added this to the 2.10 milestone Jun 1, 2024
@github-actions github-actions bot added the Neo4j label Jun 1, 2024
@nadment nadment marked this pull request as ready for review June 2, 2024 11:55
@hansva
Copy link
Contributor

hansva commented Jun 2, 2024

Nice work @nadment ! I'll take a look asap

@nadment
Copy link
Contributor Author

nadment commented Jun 2, 2024

I've found a way not to have to pass on the name of the transformation, but I'm not sure I know exactly what I'm doing, but it works.
image

@hansva hansva merged commit 28db1cc into apache:main Jun 7, 2024
2 checks passed
@github-actions github-actions bot removed this from the 2.10 milestone Jun 7, 2024
@hansva
Copy link
Contributor

hansva commented Jun 7, 2024

awesome work @nadment !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants