[HUDI-7183] Fix static insert overwrite partitions issue #10254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @boneanxs for the reiview |
boneanxs
reviewed
Dec 11, 2023
| } | ||
| val overwriteMode = if (isOverWriteTable) SaveMode.Overwrite else SaveMode.Append | ||
| val staticPartitions = if (isStaticOverwrite && !isOverWriteTable) { | ||
| val fileIndex = HoodieFileIndex(sparkSession, catalogTable.metaClient, None, combinedOpts, FileStatusCache.getOrCreate(sparkSession)) |
There was a problem hiding this comment.
cc @beyond1920, this pr tries to align with Spark that only under static overwrite mode, insert overwrite an empty dataset will overwrite the old data, this is a breaking change with #9811. Is that suitable to you?
There was a problem hiding this comment.
the behavior makes sense only with static partitioning. #9811 covers the empty input df case which is only relevant with static partitioning.
There was a problem hiding this comment.
Sorry for late response. @boneanxs I think the behavior is reasonable.
| } | ||
| val staticOverwritePartitionPathOpt = getStaticOverwritePartitionPath(catalogTable, partitionSpec, isOverWritePartition) |
There was a problem hiding this comment.
the old method can be deleted?
|
@wecharyu : can you look into the test case failures |
|
@hudi-bot run azure |
boneanxs
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Record matching static partitions for static insert_overwrite operation;
Read replaced partition fileIds through write status for dynamic insert overwrite.
Impact
Fix the issue that static insert overwrite not work for multiple partitioned table.
Risk level (write none, low medium or high below)
low.
Documentation Update
none.
Contributor's checklist