[HUDI-7443] Fix decimal conversion with legacy bytes type #10756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stream2000
commented
Feb 26, 2024
| if (schema.getType() == Schema.Type.BYTES) { | ||
| return HoodieAvroUtils.DECIMAL_CONVERSION.toBytes(bd, schema, decimal); | ||
| } else { | ||
| return HoodieAvroUtils.DECIMAL_CONVERSION.toFixed(bd, schema, decimal); |
There was a problem hiding this comment.
Without this fix, hudi will throw an exception here since bytes decimal can't call toFixed.
|
@hudi-bot run azure |
|
|
danny0405
approved these changes
Feb 27, 2024
yihua
pushed a commit
that referenced
this pull request
Feb 27, 2024
|
This may have also fixed https://issues.apache.org/jira/browse/HUDI-7388, will test and close out that issue if so. Edit: That linked issue appears to still be present in 0.15.0, within which this PR's fix should have been included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fix decimal conversion with legacy bytes type
Impact
Fix decimal conversion with legacy bytes type
Risk level (write none, low medium or high below)
low
Documentation Update
NONE
Contributor's checklist