[HUDI-7488] The BigQuerySyncTool can't work well when the hudi table schema changed #10829 #10830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steve-xi-awx thanks for the contribution. Could you attach the JIRA ticket number to the title of the PR? |
|
@yihua I don't create jira ticket. Is it necessary to create a JIRA ticket for this mr ? |
danny0405
changed the title
No worries, I have created one for you: https://issues.apache.org/jira/browse/HUDI-7488 |
danny0405
added
meta-sync
bigquery
gcp-support
|
@danny0405 Thanks, bro. I still have a question. It seems that some checks were not successfully. What should I do next ? |
|
It looks okay, all the tests passed except the supplement of the description context which is unnecessary. |
danny0405
approved these changes
Mar 8, 2024
|
@danny0405 Got it, thanks a lot. |
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The code is developed by own. It is used to fix the code bug.
When the BigQuery external table with an additional connection id, the changes of schema can't use the ExternalTableDefinition.setSchema()
I change the logic to detect if there is a connection id. And use this code to fix that bug.
Impact
On influence the update BQ schema process.
Risk level (write none, low medium or high below)
low medium
Contributor's checklist