[HUDI-7513] Add jackson-module-scala to spark bundle #10877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Mar 18, 2024
| @@ -482,6 +482,7 @@ | |||
| <include>org.apache.htrace:htrace-core4</include> | |||
| <!-- afterburner module for jackson performance --> | |||
| <include>com.fasterxml.jackson.module:jackson-module-afterburner</include> | |||
| <include>com.fasterxml.jackson.module:jackson-module-scala_${scala.binary.version}</include> | |||
| <!-- native HFile reader uses protobuf --> | |||
There was a problem hiding this comment.
cc @nsivabalan do we need to check other jackson related jars?
danny0405
approved these changes
Mar 19, 2024
|
@nsivabalan Can you check this PR? |
|
yes, we might need to fix all bundles. |
|
I searched the whole project, only jackson-module-afterburner and jackson-module-scala have the package path "com.fasterxml.jackson.module". And the fix is in the main pom, this change also takes effect for other modules. |
|
Would merge it first, we can fire following-up fix if it is necessary for specific bundles. |
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 3, 2024
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
#10097 we relocated "com.fasterxml.jackson.module",
hudi/pom.xml
Lines 582 to 586 in 2dcdd31
this changes the package path of jackson-module-scala_${scala.binary.version}.
When we do spark stream read, we will get
ClassNotFoundException: org.apache.hudi.com.fasterxml.jackson.module.scala.DefaultScalaModule$Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist