[HUDI-7523] Add HOODIE_SPARK_DATASOURCE_OPTIONS to be used in HoodieIncrSource #10900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinishjail97
changed the title
vinishjail97
changed the title
codope
reviewed
Mar 21, 2024
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieIncrSourceConfig.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieIncrSourceConfig.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java
Outdated
Show resolved
Hide resolved
| .build(); | ||
|
|
||
| TypedProperties extraProps = new TypedProperties(); | ||
| extraProps.setProperty(HoodieIncrSourceConfig.HOODIE_SPARK_DATASOURCE_OPTIONS.key(), "hoodie.metadata.enable=true,hoodie.enable.data.skipping=true"); |
There was a problem hiding this comment.
Is there also a test which actually confirms that metadata table is used and data skipping happens when reading incrementally?
There was a problem hiding this comment.
I think it might be hard to check the Spark reader contains the passed configs in the tests.
yihua
force-pushed
the
HUDI-7523-Spark-DataSource
branch
from
6800d00
to
5fefa9e
Compare
|
hey @vinishjail97 : can you address the reviews from sagar. |
yihua
force-pushed
the
HUDI-7523-Spark-DataSource
branch
from
5fefa9e
to
d0d786d
Compare
…HoodieIncrSourceConfig.java Co-authored-by: Sagar Sumit <sagarsumit09@gmail.com>
…/HoodieIncrSource.java Co-authored-by: Sagar Sumit <sagarsumit09@gmail.com>
github-actions
bot
added
size:M
yihua
approved these changes
May 12, 2024
yihua
added a commit
that referenced
this pull request
May 15, 2024
…ncrSource (#10900) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com> Co-authored-by: Sagar Sumit <sagarsumit09@gmail.com>
yihua
added a commit
that referenced
this pull request
May 15, 2024
…ncrSource (#10900) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com> Co-authored-by: Sagar Sumit <sagarsumit09@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Add a new config
HOODIE_SPARK_DATASOURCE_OPTIONSwhich is used by the spark dataframe reader for HoodieIncrSource, options like using metadataTable, dataSkipping present inDataSourceOptions.scala can be passed for efficient pruning of files.https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
Impact
The files will be pruned using colstats and other mechanisms available making
HoodieIncrSourcemore efficient.Risk level (write none, low medium or high below)
Low
Documentation Update
HOODIE_SPARK_DATASOURCE_OPTIONS is the new config being added.
A comma separate list of options that can be passed to the spark dataframe reader of a hudi table, eg: hoodie.metadata.enable=true,hoodie.enable.data.skipping=true.
Contributor's checklist