Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Add back dependency org.apache.flink:flink-connector-kafka-b… #2472

Closed
wants to merge 1 commit into from

Conversation

danny0405
Copy link
Contributor

…ase_2.11

What is the purpose of the pull request

Add back the dependency because the HoodieFlinkStreamer needs that.

Brief change log

  • Modify pom in hudi and hudi-flink-bundle module

Verify this pull request

Build locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yanghua
Copy link
Contributor

yanghua commented Jan 22, 2021

@wangxianghu Please help to review.

@@ -189,6 +190,12 @@
<artifactId>flink-connector-kafka_${scala.binary.version}</artifactId>
<scope>compile</scope>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danny0405 should we change the version of flink-connector-kafka_${scala.binary.version} to ${flink11.version} as well ?

@@ -106,6 +106,7 @@
<prometheus.version>0.8.0</prometheus.version>
<http.version>4.4.1</http.version>
<spark.version>${spark2.version}</spark.version>
<flink11.version>1.11.2</flink11.version>
<flink.version>1.12.0</flink.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we simply rollback flink verison to 1.11.2, without adding another <flink11.verison> , since hudi-flink module used the <flink.version> too.
you can add a <flink12.version> in #2430 where you need it.

@wangxianghu
Copy link
Contributor

wangxianghu commented Jan 22, 2021

@vinothchandar can we push this pr to release-0.7.0 ?
without this change , the job will throw an ClassNotFoundException:

java.lang.NoClassDefFoundError: org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at org.apache.flink.util.FlinkUserCodeClassLoader.loadClassWithoutExceptionHandling(FlinkUserCodeClassLoader.java:61)
	at org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:65)
	at org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:48)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at org.apache.hudi.HoodieFlinkStreamer.main(HoodieFlinkStreamer.java:89)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:288)
	at org.apache.flink.client.program.PackagedProgram.invokeInteractiveModeForExecution(PackagedProgram.java:198)
	at org.apache.flink.client.ClientUtils.executeProgram(ClientUtils.java:149)
	at org.apache.flink.client.cli.CliFrontend.executeProgram(CliFrontend.java:699)
	at org.apache.flink.client.cli.CliFrontend.run(CliFrontend.java:232)
	at org.apache.flink.client.cli.CliFrontend.parseParameters(CliFrontend.java:916)
	at org.apache.flink.client.cli.CliFrontend.lambda$main$10(CliFrontend.java:992)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:422)
	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1875)
	at org.apache.flink.runtime.security.contexts.HadoopSecurityContext.runSecured(HadoopSecurityContext.java:41)
	at org.apache.flink.client.cli.CliFrontend.main(CliFrontend.java:992)
Caused by: java.lang.ClassNotFoundException: org.apache.flink.streaming.connectors.kafka.FlinkKafkaConsumerBase
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at org.apache.flink.util.FlinkUserCodeClassLoader.loadClassWithoutExceptionHandling(FlinkUserCodeClassLoader.java:61)
	at org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:65)
	at org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:48)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	... 31 more

@wangxianghu
Copy link
Contributor

wangxianghu commented Jan 22, 2021

talked with @danny0405 offline
we decide to rollback #2384
new change goes to #2473

@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #2472 (0a425c7) into master (048633d) will increase coverage by 19.25%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2472       +/-   ##
=============================================
+ Coverage     50.17%   69.43%   +19.25%     
+ Complexity     3050      357     -2693     
=============================================
  Files           419       53      -366     
  Lines         18931     1930    -17001     
  Branches       1948      230     -1718     
=============================================
- Hits           9498     1340     -8158     
+ Misses         8657      456     -8201     
+ Partials        776      134      -642     
Flag Coverage Δ Complexity Δ
hudicli ? ?
hudiclient ? ?
hudicommon ? ?
hudiflink ? ?
hudihadoopmr ? ?
hudisparkdatasource ? ?
hudisync ? ?
huditimelineservice ? ?
hudiutilities 69.43% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../org/apache/hudi/common/model/HoodieFileGroup.java
...ache/hudi/common/fs/SizeAwareDataOutputStream.java
...mmon/table/log/HoodieUnMergedLogRecordScanner.java
...e/hudi/exception/HoodieCorruptedDataException.java
...apache/hudi/common/util/collection/RocksDBDAO.java
...che/hudi/metadata/TimelineMergedTableMetadata.java
...cala/org/apache/hudi/HoodieBootstrapRelation.scala
...org/apache/hudi/cli/commands/RollbacksCommand.java
...i/hadoop/utils/HoodieRealtimeInputFormatUtils.java
...in/java/org/apache/hudi/cli/HoodiePrintHelper.java
... and 356 more

@yanghua
Copy link
Contributor

yanghua commented Jan 22, 2021

@wangxianghu Can we close this PR now?

@yanghua yanghua self-assigned this Jan 22, 2021
@yanghua
Copy link
Contributor

yanghua commented Jan 22, 2021

@danny0405 I am closing this PR now because @wangxianghu fixed it via PR #2473 . Please feel free to reopen it if you have any opinions.

@yanghua yanghua closed this Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants