-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Add back dependency org.apache.flink:flink-connector-kafka-b… #2472
Conversation
@wangxianghu Please help to review. |
@@ -189,6 +190,12 @@ | |||
<artifactId>flink-connector-kafka_${scala.binary.version}</artifactId> | |||
<scope>compile</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danny0405 should we change the version of flink-connector-kafka_${scala.binary.version}
to ${flink11.version}
as well ?
@@ -106,6 +106,7 @@ | |||
<prometheus.version>0.8.0</prometheus.version> | |||
<http.version>4.4.1</http.version> | |||
<spark.version>${spark2.version}</spark.version> | |||
<flink11.version>1.11.2</flink11.version> | |||
<flink.version>1.12.0</flink.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we simply rollback flink verison to 1.11.2, without adding another <flink11.verison>
, since hudi-flink
module used the <flink.version>
too.
you can add a <flink12.version>
in #2430 where you need it.
@vinothchandar can we push this pr to release-0.7.0 ?
|
talked with @danny0405 offline |
Codecov Report
@@ Coverage Diff @@
## master #2472 +/- ##
=============================================
+ Coverage 50.17% 69.43% +19.25%
+ Complexity 3050 357 -2693
=============================================
Files 419 53 -366
Lines 18931 1930 -17001
Branches 1948 230 -1718
=============================================
- Hits 9498 1340 -8158
+ Misses 8657 456 -8201
+ Partials 776 134 -642
Flags with carried forward coverage won't be shown. Click here to find out more. |
@wangxianghu Can we close this PR now? |
@danny0405 I am closing this PR now because @wangxianghu fixed it via PR #2473 . Please feel free to reopen it if you have any opinions. |
…ase_2.11
What is the purpose of the pull request
Add back the dependency because the
HoodieFlinkStreamer
needs that.Brief change log
Verify this pull request
Build locally.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.