[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config #3250

codope · 2021-07-09T12:14:29Z

What is the purpose of the pull request

EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config key depends on AVRO_SCHEMA, which is no longer a static string. This PR sets the key correctly for the aforementioned config.

Verify this pull request

This pull request is already covered by existing tests, such as TestHoodieWriteConfig. Added assert for this particular config to verify the fix.

Committer checklist

Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

hudi-bot · 2021-07-09T12:18:12Z

CI report:

01525c9 Azure: FAILURE

Bot commands

@hudi-bot supports the following commands:

@hudi-bot run travis re-run the last Travis build
@hudi-bot run azure re-run the last Azure build

codecov-commenter · 2021-07-09T16:37:33Z

Codecov Report

Merging #3250 (01525c9) into master (ca440cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3250   +/-   ##
=========================================
  Coverage     47.71%   47.72%           
- Complexity     5527     5528    +1     
=========================================
  Files           934      934           
  Lines         41456    41457    +1     
  Branches       4167     4167           
=========================================
+ Hits          19782    19785    +3     
+ Misses        19916    19914    -2     
  Partials       1758     1758

Flag	Coverage Δ
hudicli	`39.97% <ø> (ø)`
hudiclient	`34.46% <100.00%> (+0.01%)`	⬆️
hudicommon	`48.57% <ø> (-0.01%)`	⬇️
hudiflink	`60.03% <ø> (ø)`
hudihadoopmr	`51.55% <ø> (ø)`
hudisparkdatasource	`67.37% <ø> (+0.05%)`	⬆️
hudisync	`54.51% <ø> (ø)`
huditimelineservice	`64.07% <ø> (ø)`
hudiutilities	`59.26% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...java/org/apache/hudi/config/HoodieWriteConfig.java	`43.07% <100.00%> (+0.26%)`	⬆️
...e/hudi/common/table/log/HoodieLogFormatWriter.java	`78.90% <0.00%> (-0.79%)`	⬇️
...in/scala/org/apache/hudi/HoodieStreamingSink.scala	`29.60% <0.00%> (+1.60%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca440cc...01525c9. Read the comment docs.

nsivabalan · 2021-07-09T16:39:35Z

hudi-client/hudi-client-common/src/test/java/org/apache/hudi/config/TestHoodieWriteConfig.java

@@ -43,6 +43,7 @@ public void testPropertyLoading() throws IOException {
    params.put(HoodieCompactionConfig.CLEANER_COMMITS_RETAINED_PROP.key(), "1");
    params.put(HoodieCompactionConfig.MAX_COMMITS_TO_KEEP_PROP.key(), "5");
    params.put(HoodieCompactionConfig.MIN_COMMITS_TO_KEEP_PROP.key(), "2");
+    params.put("hoodie.avro.schema.externalTransformation", "true");


shouldn't we use EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION.key() here?

We can but that would have passed even without the fix. I thought to put what users would actually put in props file.

leesf · 2021-07-12T14:51:31Z

hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java

@@ -339,7 +339,7 @@
      .withDocumentation("");

  public static final ConfigProperty<String> EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION = ConfigProperty
-      .key(AVRO_SCHEMA + ".externalTransformation")
+      .key(AVRO_SCHEMA.key() + ".externalTransformation")


when using spark option("hoodie.avro.schema.externalTransformation", true) to pass the config, the externalTransformation will be changed to lowercase externaltransformation , can we fix it?

I see. We can either remove the camel case and break the key as hoodie.avro.schema.external.transformation, or just ignore case in comparison. What would you recommend?

I prefer hoodie.avro.schema.external.transformation to align with other configs.

Changed the config key to hoodie.avro.schema.external.transformation and also have hoodie.avro.schema.externalTransformation as alternative for backwards compatibility.

Align config key with alternative

change the insret overwrte return type [HUDI-1860] Test wrapper for insert_overwrite and insert_overwrite_table [HUDI-2084] Resend the uncommitted write metadata when start up (apache#3168) Co-authored-by: 喻兆靖 <yuzhaojing@bilibili.com> [HUDI-2081] Move schema util tests out from TestHiveSyncTool (apache#3166) [HUDI-2094] Supports hive style partitioning for flink writer (apache#3178) [HUDI-2097] Fix Flink unable to read commit metadata error (apache#3180) [HUDI-2085] Support specify compaction paralleism and compaction target io for flink batch compaction (apache#3169) [HUDI-2092] Fix NPE caused by FlinkStreamerConfig#writePartitionUrlEncode null value (apache#3176) [HUDI-2006] Adding more yaml templates to test suite (apache#3073) [HUDI-2103] Add rebalance before index bootstrap (apache#3185) Co-authored-by: 喻兆靖 <yuzhaojing@bilibili.com> [HUDI-1944] Support Hudi to read from committed offset (apache#3175) * [HUDI-1944] Support Hudi to read from committed offset * [HUDI-1944] Adding group option to KafkaResetOffsetStrategies * [HUDI-1944] Update Exception msg [HUDI-2052] Support load logFile in BootstrapFunction (apache#3134) Co-authored-by: 喻兆靖 <yuzhaojing@bilibili.com> [HUDI-89] Add configOption & refactor all configs based on that (apache#2833) Co-authored-by: Wenning Ding <wenningd@amazon.com> [MINOR] Update .asf.yaml to codify notification settings, turn on jira comments, gh discussions (apache#3164) - Turn on comment for jira, so we can track PR activity better - Create a notification settings that match https://gitbox.apache.org/schemes.cgi?hudi - Try and turn on "discussions" on Github, to experiment [MINOR] Fix broken build due to FlinkOptions (apache#3198) [HUDI-2088] Missing Partition Fields And PreCombineField In Hoodie Properties For Table Written By Flink (apache#3171) [MINOR] Add Documentation to KEYGENERATOR_TYPE_PROP (apache#3196) [HUDI-2105] Compaction Failed For MergeInto MOR Table (apache#3190) [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql (apache#3126) [HUDI-2112] Support reading pure logs file group for flink batch reader after compaction (apache#3202) [HUDI-2114] Spark Query MOR Table Written By Flink Return Incorrect Timestamp Value (apache#3208) [HUDI-2121] Add operator uid for flink stateful operators (apache#3212) [HUDI-2123] Exception When Merge With Null-Value Field (apache#3214) [HUDI-2124] A Grafana dashboard for HUDI. (apache#3216) [HUDI-2057] CTAS Generate An External Table When Create Managed Table (apache#3146) [HUDI-1930] Bootstrap support configure KeyGenerator by type (apache#3170) * [HUDI-1930] Bootstrap support configure KeyGenerator by type [HUDI-2116] Support batch synchronization of partition datas to hive metastore to avoid oom problem (apache#3209) [HUDI-2126] The coordinator send events to write function when there are no data for the checkpoint (apache#3219) [HUDI-2127] Initialize the maxMemorySizeInBytes in log scanner (apache#3220) [HUDI-2058]support incremental query for insert_overwrite_table/insert_overwrite operation on cow table (apache#3139) [HUDI-2129] StreamerUtil.medianInstantTime should return a valid date time string (apache#3221) [HUDI-2131] Exception Throw Out When MergeInto With Decimal Type Field (apache#3224) [HUDI-2122] Improvement in packaging insert into smallfiles (apache#3213) [HUDI-2132] Make coordinator events as POJO for efficient serialization (apache#3223) [HUDI-2106] Fix flink batch compaction bug while user don't set compaction tasks (apache#3192) [HUDI-2133] Support hive1 metadata sync for flink writer (apache#3225) [HUDI-2089]fix the bug that metatable cannot support non_partition table (apache#3182) [HUDI-2028] Implement RockDbBasedMap as an alternate to DiskBasedMap in ExternalSpillableMap (apache#3194) Co-authored-by: Rajesh Mahindra <rmahindra@Rajeshs-MacBook-Pro.local> [HUDI-2135] Add compaction schedule option for flink (apache#3226) [HUDI-2055] Added deltastreamer metric for time of lastSync (apache#3129) [HUDI-2046] Loaded too many classes like sun/reflect/GeneratedSerializationConstructorAccessor in JVM metaspace (apache#3121) Loaded too many classes when use kryo of spark to hudi Co-authored-by: weiwei.duan <weiwei.duan@linkflowtech.com> [HUDI-1996] Adding functionality to allow the providing of basic auth creds for confluent cloud schema registry (apache#3097) * adding support for basic auth with confluent cloud schema registry [HUDI-2093] Fix empty avro schema path caused by duplicate parameters (apache#3177) * [HUDI-2093] Fix empty avro schema path caused by duplicate parameters * rename shcmea option key * fix doc * rename var name [HUDI-2113] Fix integration testing failure caused by sql results out of order (apache#3204) [HUDI-2016] Fixed bootstrap of Metadata Table when some actions are in progress. (apache#3083) Metadata Table cannot be bootstrapped when any action is in progress. This is detected by the presence of inflight or requested instants. The bootstrapping is initiated in preWrite and postWrite of each commit. So bootstrapping will be retried again until it succeeds. Also added metrics for when the bootstrapping fails or a table is re-bootstrapped. This will help detect tables which are not getting bootstrapped. [HUDI-2140] Fixed the unit test TestHoodieBackedMetadata.testOnlyValidPartitionsAdded. (apache#3234) [HUDI-2115] FileSlices in the filegroup is not descending by timestamp (apache#3206) [HUDI-1104] Adding support for UserDefinedPartitioners and SortModes to BulkInsert with Rows (apache#3149) [HUDI-2069] Refactored String constants (apache#3172) [HUDI-1105] Adding dedup support for Bulk Insert w/ Rows (apache#2206) [HUDI-2134]Add generics to avoif forced conversion in BaseSparkCommitActionExecutor#partition (apache#3232) [HUDI-2009] Fixing extra commit metadata in row writer path (apache#3075) [HUDI-2099]hive lock which state is WATING should be released, otherwise this hive lock will be locked forever (apache#3186) [MINOR] Fix build broken from apache#3186 (apache#3245) [HUDI-2136] Fix conflict when flink-sql-connector-hive and hudi-flink-bundle are both in flink lib (apache#3227) [HUDI-2087] Support Append only in Flink stream (apache#3174) Co-authored-by: 喻兆靖 <yuzhaojing@bilibili.com> UnitTest for deltaSync Removing cosmetic changes and reuse function for insert_overwrite_table unit test intial unit test for the insert_overwrite and insert_over_write_table Adding failed test code for insert_overwrite Revert "[HUDI-2087] Support Append only in Flink stream (apache#3174)" (apache#3251) This reverts commit 3715267. [HUDI-2147] Remove unused class AvroConvertor in hudi-flink (apache#3243) [MINOR] Fix some wrong assert reasons (apache#3248) [HUDI-2087] Support Append only in Flink stream (apache#3252) Co-authored-by: 喻兆靖 <yuzhaojing@bilibili.com> [HUDI-2143] Tweak the default compaction target IO to 500GB when flink async compaction is off (apache#3238) [HUDI-2142] Support setting bucket assign parallelism for flink write task (apache#3239) [HUDI-1483] Support async clustering for deltastreamer and Spark streaming (apache#3142) - Integrate async clustering service with HoodieDeltaStreamer and HoodieStreamingSink - Added methods in HoodieAsyncService to reuse code [HUDI-2107] Support Read Log Only MOR Table For Spark (apache#3193) [HUDI-2144]Bug-Fix:Offline clustering(HoodieClusteringJob) will cause insert action losing data (apache#3240) * fixed * add testUpsertPartitionerWithSmallFileHandlingAndClusteringPlan ut * fix CheckStyle Co-authored-by: yuezhang <yuezhang@freewheel.tv> [MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config (apache#3250) [HUDI-2168] Fix for AccessControlException for anonymous user (apache#3264) [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And DeltaStreamer test with insert-overwrite and insert-overwrite-table removing hardcoded action to pass the unit test [HUDI-1969] Support reading logs for MOR Hive rt table (apache#3033) [HUDI-2171] Add parallelism conf for bootstrap operator using delta-commit for insert_overwrite

…3250)

nsivabalan reviewed Jul 9, 2021

View reviewed changes

leesf reviewed Jul 12, 2021

View reviewed changes

[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config

01525c9

Align config key with alternative

codope force-pushed the fix-write-config branch from 0420f87 to 01525c9 Compare July 12, 2021 17:22

nsivabalan approved these changes Jul 13, 2021

View reviewed changes

nsivabalan merged commit b0089b8 into apache:master Jul 13, 2021

ghost pushed a commit to shivagowda/hudi that referenced this pull request Jul 17, 2021

[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config (apache#…

071e277

…3250)

ghost pushed a commit to shivagowda/hudi that referenced this pull request Aug 1, 2021

[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config (apache#…

ee3061e

…3250)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config #3250

[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config #3250

codope commented Jul 9, 2021

hudi-bot commented Jul 9, 2021 •

edited

Loading

codecov-commenter commented Jul 9, 2021 •

edited

Loading

nsivabalan Jul 9, 2021

codope Jul 9, 2021

leesf Jul 12, 2021

codope Jul 12, 2021

leesf Jul 12, 2021

codope Jul 13, 2021

[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config #3250

[MINOR] Fix EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION config #3250

Conversation

codope commented Jul 9, 2021

What is the purpose of the pull request

Verify this pull request

Committer checklist

hudi-bot commented Jul 9, 2021 • edited Loading

CI report:

codecov-commenter commented Jul 9, 2021 • edited Loading

Codecov Report

nsivabalan Jul 9, 2021

Choose a reason for hiding this comment

codope Jul 9, 2021

Choose a reason for hiding this comment

leesf Jul 12, 2021

Choose a reason for hiding this comment

codope Jul 12, 2021

Choose a reason for hiding this comment

leesf Jul 12, 2021

Choose a reason for hiding this comment

codope Jul 13, 2021

Choose a reason for hiding this comment

hudi-bot commented Jul 9, 2021 •

edited

Loading

codecov-commenter commented Jul 9, 2021 •

edited

Loading