Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-3157] Remove aws jars from hudi bundles #4542

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

boneanxs
Copy link
Contributor

@boneanxs boneanxs commented Jan 9, 2022

Tips

What is the purpose of the pull request

Remove aws jars from hudi bundles to align with flink-bundle
ref: #4474

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@boneanxs
Copy link
Contributor Author

boneanxs commented Jan 9, 2022

@xushiyan @nsivabalan pls take a took.

@hudi-bot
Copy link

hudi-bot commented Jan 9, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan xushiyan self-assigned this Jan 9, 2022
@xushiyan xushiyan merged commit 977d3c6 into apache:master Jan 9, 2022
melin added a commit to melin/hudi that referenced this pull request Jan 9, 2022
@parisni
Copy link
Contributor

parisni commented Jan 10, 2022

@boneanxs what about also relocating the aws dependency in hudi-aws ? because this alone don't help for aws sdk version mismatch in case they use the dynamodb-lock . they still need to have there own hudi build with shadow relocation ?

nsivabalan pushed a commit that referenced this pull request Jan 11, 2022
Co-authored-by: Hui An <hui.an@shopee.com>
@vinishjail97 vinishjail97 mentioned this pull request Jan 24, 2022
5 tasks
vingov pushed a commit to vingov/hudi that referenced this pull request Jan 26, 2022
Co-authored-by: Hui An <hui.an@shopee.com>
liusenhua pushed a commit to liusenhua/hudi that referenced this pull request Mar 1, 2022
Co-authored-by: Hui An <hui.an@shopee.com>
@vinothchandar
Copy link
Member

@xushiyan I think a better approach would be to provide a hudi-aws-bundle with all the different dependencies for aws separately? As @parisni points out as well, there are more issues here? Can we summarize how we are on master and if anything needs to be done before the release.

vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
Co-authored-by: Hui An <hui.an@shopee.com>
@xushiyan
Copy link
Member

@xushiyan I think a better approach would be to provide a hudi-aws-bundle with all the different dependencies for aws separately? As @parisni points out as well, there are more issues here? Can we summarize how we are on master and if anything needs to be done before the release.

as discussed, we should have the aws bundle with some dep issue resolved https://issues.apache.org/jira/browse/HUDI-3878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SUPPORT] Should we shade all aws dependencies to avoid class conflicts?
5 participants