Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-1575] Early Conflict Detection For Multi-writer #6059

Conversation

zhangyue19921010
Copy link
Contributor

Please take a look at #6003 for more details.

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yihua yihua added priority:blocker multi-writer writer-core Issues relating to core transactions/write actions labels Jul 7, 2022
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@zhangyue19921010
Copy link
Contributor Author

Added four cases for early conflict detection multi-writing:

  1. COPY_ON_WRITE + TIMELINE_SERVER_BASED MARKER
  2. MERGE_ON_READ + TIMELINE_SERVER_BASED MARKER
  3. MERGE_ON_READ + DIRECT MARKER
  4. COPY_ON_WRITE + DIRECT MARKER

Also all the tests are passed including these new four cases.

I believe this PR is ready for reviewing. PTAL :)

@zhangyue19921010
Copy link
Contributor Author

replaced by #6133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big-needle-movers multi-writer priority:blocker writer-core Issues relating to core transactions/write actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants