Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5102] source operator(monitor and reader) support user uid #7011

Closed
wants to merge 5 commits into from
Closed

[HUDI-5102] source operator(monitor and reader) support user uid #7011

wants to merge 5 commits into from

Conversation

1032851561
Copy link
Contributor

@1032851561 1032851561 commented Oct 20, 2022

source operator(monitor and reader) support user uid

Tips

What is the purpose of the pull request

https://issues.apache.org/jira/browse/HUDI-5090

Brief change log

refer to org.apache.hudi.sink.utils.Pipelines#hoodieStreamWrite , add user uid for StreamReadMonitoringFunction and StreamReadOperator

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

source operator(monitor and reader) support user uid
@1032851561 1032851561 changed the title Update HoodieTableSource.java source operator(monitor and reader) support user uid Oct 20, 2022
@nsivabalan nsivabalan added priority:minor everything else; usability gaps; questions; feature reqs flink Issues related to flink labels Oct 21, 2022
@XuQianJin-Stars
Copy link
Contributor

@hudi-bot run azure

.setParallelism(1)
.keyBy(MergeOnReadInputSplit::getFileId)
.transform("split_reader", typeInfo, factory)
.uid("uid_split_reader_" + conf.getString(FlinkOptions.TABLE_NAME))
.setParallelism(conf.getInteger(FlinkOptions.READ_TASKS));
return new DataStreamSource<>(source);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse the util method: opItentifier ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I have optimized it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you apply the review patch though ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you notice that i have pasted a patch under the comments, you can apply the patch with command:

git apply xxx.patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@danny0405
Copy link
Contributor

fix_op_uid.patch.zip
Thanks for the contribution, i have reviewed and applied a patch, can you
log a JIRA issue here:
https://issues.apache.org/jira/projects/HUDI/issues/HUDI-5066?filter=allopenissues

and change your commit title into:
[HUDI-${JIRA_ID}] ${your commit title}

@1032851561 1032851561 changed the title source operator(monitor and reader) support user uid [HUDI-5066] source operator(monitor and reader) support user uid Oct 27, 2022
@1032851561 1032851561 changed the title [HUDI-5066] source operator(monitor and reader) support user uid source operator(monitor and reader) support user uid Oct 27, 2022
@1032851561 1032851561 changed the title source operator(monitor and reader) support user uid [HUDI-5102] source operator(monitor and reader) support user uid Oct 27, 2022
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@danny0405
Copy link
Contributor

@hudi-bot run azure

@danny0405
Copy link
Contributor

Hi, can you rebase with the latest master and force push with the branch ?

@1032851561 1032851561 closed this Oct 28, 2022
@1032851561 1032851561 reopened this Oct 28, 2022
@1032851561
Copy link
Contributor Author

1032851561 commented Oct 28, 2022

Hi, can you rebase with the latest master and force push with the branch ?

I have create new branch "fix_op_uid" and pull request again #7085

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405
Copy link
Contributor

Close because it is fixed in #7085.

@danny0405 danny0405 closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flink Issues related to flink priority:minor everything else; usability gaps; questions; feature reqs
Projects
Status: Awaiting Triage
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants