Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ManifestEvaluator to prune mainfest files. #253

Closed
Tracked by #153
liurenjie1024 opened this issue Mar 11, 2024 · 6 comments
Closed
Tracked by #153

Implement ManifestEvaluator to prune mainfest files. #253

liurenjie1024 opened this issue Mar 11, 2024 · 6 comments
Milestone

Comments

@liurenjie1024
Copy link
Collaborator

liurenjie1024 commented Mar 11, 2024

See python implementation

Blocked by #264.

@waynexia
Copy link
Member

I suppose this issue has been taken according to #241 (comment)?

@liurenjie1024
Copy link
Collaborator Author

I suppose this issue has been taken according to #241 (comment)?

Not yet, there are some dependencies not implemented yet, I'll open issues and clarify their dependencies.

@marvinlanhenke
Copy link
Contributor

@liurenjie1024
Is it correct that we need to implement the ProjectionEvaluator beforehand in order to provide the partition_filters
and extend TableScan with row_filter: Predicate?

https://github.com/apache/iceberg-python/blob/4ed5a144ecad69878cf47292557b17df31ffe5a8/pyiceberg/table/__init__.py#L753-L763

@liurenjie1024
Copy link
Collaborator Author

@liurenjie1024 Is it correct that we need to implement the ProjectionEvaluator beforehand in order to provide the partition_filters and extend TableScan with row_filter: Predicate?

https://github.com/apache/iceberg-python/blob/4ed5a144ecad69878cf47292557b17df31ffe5a8/pyiceberg/table/__init__.py#L753-L763

Yes, and before that we need to implement project for transform.

@marvinlanhenke
Copy link
Contributor

I just browsed the issues, you've already listed the dependencies here:
linking this for ref:
#153

@liurenjie1024
Copy link
Collaborator Author

Close by #322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants