refactor: remove support of manifest list format as a list of file path (#158) #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dysprosium0626
force-pushed
the
remove-support-of-manifest-list-format-as-a-list-of-file-paths
branch
3 times, most recently
from
14c3ae2
to
acb4422
Compare
There was a problem hiding this comment.
@Dysprosium0626 Thanks for this pr, it looks great! I've left some small comments to improve.
crates/iceberg/src/spec/snapshot.rs
Outdated
| (Some(file), _) => ManifestListLocation::ManifestListFile(file), | ||
| (None, Some(files)) => ManifestListLocation::ManifestFiles(files), | ||
| (None, None) => { | ||
| manifest_list: match v1.manifest_list { |
There was a problem hiding this comment.
We should change this to report error better:
match (v1.manifest_list, v1.manifests) {
(Some(file), None) => file,
(Some(file), Some(_)) => "Invalid v1 snapshot, when manifest list provided, manifest files should be omitted",
(None, _) => "Unsupported v1 snapshot, only manifest list is supported"
}
crates/iceberg/src/spec/snapshot.rs
Outdated
| @@ -262,8 +243,6 @@ pub(super) mod _serde { | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub manifest_list: Option<String>, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub manifests: Option<Vec<String>>, | |||
There was a problem hiding this comment.
I think we should still keep this field for better error reporting.
Dysprosium0626
force-pushed
the
remove-support-of-manifest-list-format-as-a-list-of-file-paths
branch
from
bc6c183
to
03f77b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims for issue #158. Since we don't plan to support the manifest list as manifest list file, we will remove support for it. I remove all
ManifestListLocation::ManifestFilesand and replace allManifestListLocation::ManifestListFilewithString